khepri_tree: Ignore unknown props to return #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
==========================================
- Coverage 89.73% 89.42% -0.31%
==========================================
Files 22 22
Lines 3263 3263
==========================================
- Hits 2928 2918 -10
- Misses 335 345 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
[Why] A future version of Khepri might introduce new props to return. If a Khepri cluster is being upgraded and several versions of the Khepri machine are running at the same time, an old node could be called with props to return it doesn’t know. [How] We simply ignore unknown props. In the process, we ignore `delete_reason` because it is set by another part of the code anyway.
dumbbell
force-pushed
the
ignore-unknown-props_to_return
branch
from
5c73387 to
257cf32
Compare
the-mikedavis
approved these changes
Dec 11, 2024
dumbbell
added a commit
that referenced
this pull request
Dec 12, 2024
…>= 2 only [Why] The `delete_reason` property to return was introduced with machine version 2. Older versions have two issues: * They don't know this property * They crash on unknown properties [How] We request this new property only if the effective machine version is greater or equal to 2 to avoid the issues listed above. Future unknown properties are ignored since commit 257cf32 merged in the previous pull request #308.
dumbbell
added a commit
that referenced
this pull request
Dec 12, 2024
…>= 2 only [Why] The `delete_reason` property to return was introduced with machine version 2. Older versions have two issues: * They don't know this property * They crash on unknown properties [How] We request this new property only if the effective machine version is greater or equal to 2 to avoid the issues listed above. Future unknown properties are ignored since commit 257cf32 merged in the previous pull request #308.
dumbbell
added a commit
that referenced
this pull request
Dec 12, 2024
…>= 2 only [Why] The `delete_reason` property to return was introduced with machine version 2. Older versions have two issues: * They don't know this property * They crash on unknown properties [How] We request this new property only if the effective machine version is greater or equal to 2 to avoid the issues listed above. Future unknown properties are ignored since commit 257cf32 merged in the previous pull request #308.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
A future version of Khepri might introduce new props to return. If a Khepri cluster is being upgraded and several versions of the Khepri machine are running at the same time, an old node could be called with props to return it doesn’t know.
How
We simply ignore unknown props.
In the process, we ignore
delete_reasonbecause it is set by another part of the code anyway.