Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed getting a users' name on UserData collections #2591

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix: fixed getting a users' name on UserData collections #2591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lms/djangoapps/grades/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ def _emit_course_passing_status_update(user, course_id, is_passing):
pii=UserPersonalData(
username=user.username,
email=user.email,
name=user.get_full_name(),
name=user.get_full_name() or user.profile.name,
),
id=user.id,
is_active=user.is_active,
Expand All @@ -305,7 +305,7 @@ def _emit_course_passing_status_update(user, course_id, is_passing):
pii=UserPersonalData(
username=user.username,
email=user.email,
name=user.get_full_name(),
name=user.get_full_name() or user.profile.name,
),
id=user.id,
is_active=user.is_active,
Expand Down
4 changes: 2 additions & 2 deletions lms/djangoapps/grades/tests/test_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def test_course_passing_status_updated_emitted(self):
pii=UserPersonalData(
username=self.user.username,
email=self.user.email,
name=self.user.get_full_name(),
name=self.user.get_full_name() or self.user.profile.name,
),
id=self.user.id,
is_active=self.user.is_active,
Expand Down Expand Up @@ -234,7 +234,7 @@ def test_ccx_course_passing_status_updated_emitted(self):
pii=UserPersonalData(
username=self.user.username,
email=self.user.email,
name=self.user.get_full_name(),
name=self.user.get_full_name() or self.user.profile.name,
),
id=self.user.id,
is_active=self.user.is_active,
Expand Down
2 changes: 1 addition & 1 deletion lms/djangoapps/verify_student/signals/signals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def _create_user_data(user):
pii=UserPersonalData(
username=user.username,
email=user.email,
name=user.get_full_name()
name=user.get_full_name() or user.profile.name
)
)

Expand Down
Loading