Updates to process_mon.sh and ubuntu_updates_check.sh #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzg
reviewed
Aug 3, 2018
process_mon.sh
Outdated
| @@ -64,4 +68,12 @@ if [ -z "$1" ]; then | |||
| fi | |||
|
|
|||
| process_check=`ps ax | grep -v grep | grep -v process_mon | grep -c "$1"` | |||
| if (( $process_check > 0 )); then | |||
| process_age=`ps -o etimes= -p "$process_check"` | |||
There was a problem hiding this comment.
Since $process_check will contain either 0 or 1 from the grep -c this doesn't seem to grab the etimes from the intended pid.
|
Oops thought it was getting a PID. Let me try again |
tcaddy
changed the title
itzg
reviewed
Mar 20, 2019
ubuntu_updates_check.sh
Outdated
| PENDING_OTHER=$(echo "${OUTPUT}" | cut -d ";" -f 1) | ||
| PENDING_SECURITY=$(echo "${OUTPUT}" | cut -d ";" -f 2) | ||
| PENDING_OTHER=$(echo "${OUTPUT}" | grep -v "Listing..." | grep -v "/$(lsb_release -cs)-security" | wc -l) | ||
| PENDING_SECURITY=$(echo "${OUTPUT}" | grep -v "Listing..." | grep "/$(lsb_release -cs)-security" | wc -l) |
There was a problem hiding this comment.
I did a quick test and noticed that some packages on my system are available via both channels, so the pattern here needs to match a leading slash or comma in order to match:
ruby1.9.1-dev/trusty-updates,trusty-security 1.9.3.484-2ubuntu1.13 amd64 [upgradable from: 1.9.3.484-2ubuntu1.7]
* /usr/lib/update-notifier/apt-check was not returning a count of upgradeable packages on various machines even though you could see packages available for update via `apt-get update` * Replace with `apt list --upgradeable` and parse out the count of upgradeable security and non-security package updates available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to process_mon.sh
Add an additional metric
process_ageto theprocess_mon.shscript. This will allow you to raise an alarm if a process has been running for too long.Updates to ubuntu_update_check.sh
/usr/lib/update-notifier/apt-checkwas not returning a count of upgradeable packages on various machines even though you could see packages available for update viaapt-get upgradeapt list --upgradeableand parse out the count of upgradeable security and non-security package updates available