-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds some tests for racket/htdp#228, racket/htdp#229 and racket/htdp#230 #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow `-e`/`--check-stderr` does not work with `tests/drracket/module-lang-test` (perhaps due to using `test-log` + `exit 0` in `fire-up-drracket-and-run-tests`?)
This was referenced Oct 26, 2024
In tests/drracket/module-lang-test, stderr goes through a pipe to be checked for the absence of error messages. Therefore, sleep for 0.1s before existing to let the background thread pipe the messages to terminal.
shhyou
changed the title
Adds some tests for racket/htdp#228 and racket/htdp#229
Adds some tests for racket/htdp#228, racket/htdp#229 and racket/htdp#230
Oct 27, 2024
shhyou
added a commit
to racket/htdp
that referenced
this pull request
Nov 9, 2024
* Request errortrace to annotate check-* thunks * Fix the format string of check-within errors. When reporting "not given an inexact number" in check-within, the given value has to be formatted with ~s since it could have been a string: (check-within (sqrt 2) 3/2 "0.1") * Fix check-random error message so check-randoms don't report themselves as check-expect anymore. * Revise check-expect error messages + Refer to "the second argument" in the messages + Remove the fix suggestion per the comment <#228 (comment)> See tests/drracket/module-lang-tests for the tests (racket/drracket#689).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some tests for racket/htdp#228, racket/htdp#229 and racket/htdp#230.