Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds some tests for racket/htdp#228, racket/htdp#229 and racket/htdp#230 #689

Merged
merged 10 commits into from
Nov 11, 2024

Conversation

shhyou
Copy link
Collaborator

@shhyou shhyou commented Oct 26, 2024

This PR adds some tests for racket/htdp#228, racket/htdp#229 and racket/htdp#230.

Somehow `-e`/`--check-stderr` does not work with `tests/drracket/module-lang-test`
(perhaps due to using `test-log` + `exit 0` in `fire-up-drracket-and-run-tests`?)
github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

In tests/drracket/module-lang-test, stderr goes through a pipe to be checked
for the absence of error messages. Therefore, sleep for 0.1s before existing
to let the background thread pipe the messages to terminal.
github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

@shhyou shhyou changed the title Adds some tests for racket/htdp#228 and racket/htdp#229 Adds some tests for racket/htdp#228, racket/htdp#229 and racket/htdp#230 Oct 27, 2024
github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

@shhyou shhyou marked this pull request as ready for review November 2, 2024 16:55
github-actions[bot]

This comment was marked as resolved.

shhyou added a commit to racket/htdp that referenced this pull request Nov 9, 2024
* Request errortrace to annotate check-* thunks

* Fix the format string of check-within errors.

  When reporting "not given an inexact number" in check-within, the given
  value has to be formatted with ~s since it could have been a string:

      (check-within (sqrt 2) 3/2 "0.1")

* Fix check-random error message so check-randoms don't report
  themselves as check-expect anymore.

* Revise check-expect error messages
   + Refer to "the second argument" in the messages
   + Remove the fix suggestion per the comment <#228 (comment)>

See tests/drracket/module-lang-tests for the tests (racket/drracket#689).
@shhyou shhyou merged commit 0375cc8 into racket:master Nov 11, 2024
1 of 3 checks passed
@shhyou shhyou deleted the htdp-tests branch November 19, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant