Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at generic collection interfaces #259

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions rhombus/data/collection.rhm
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
#lang rhombus


export:
Collection
CollectionView
MutableCollection


import:
rhombus/data/sequence.Sequence


interface CollectionView:
extends Sequence
// read-only property
property size :: Integer

method isEmpty() :: Boolean: size() == 0

method contains(element) :: Boolean:
let iterator = iterate()
fun loop():
iterator.hasNext() && (iterator.next() == element || loop())
loop()


interface Collection:
extends CollectionView
method add(element) :: Collection
method remove(element) :: Collection


interface MutableCollection:
extends CollectionView
method add(element) :: Void

method addAll(elements :: Sequence) :: Void:
let iterator = elements.iterate()
fun loop():
when iterator.hasNext()
| add(iterator.next())
loop()
loop()

method remove(element) :: Void
method clear() :: Void
31 changes: 31 additions & 0 deletions rhombus/data/list.rhm
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
#lang rhombus


export:
List
ListView
MutableList


import:
rhombus/data/private/array_list.ArrayList
rhombus/data/private/list.List
rhombus/data/private/list.ListView
rhombus/data/private/list.MutableList
rhombus/data/private/list_builder.ListBuilder


fun List.builder(): ListBuilder()


// TODO: make this work as List(...) instead of List.of(...)
fun List.of(element, ...):
let builder = List.builder()
for:
each v: Array(element, ...)
builder.add(v)
builder.build()


// TODO: make this work as MutableList() instead of MutableList.create()
fun MutableList.create(): ArrayList()
184 changes: 184 additions & 0 deletions rhombus/data/private/array_list.rhm
Original file line number Diff line number Diff line change
@@ -0,0 +1,184 @@
#lang rhombus


export:
ArrayList


import:
rhombus/data/private/list.MutableList
rhombus/data/sequence.Iterator
lib("racket/base.rkt").error


class ArrayList():
implements MutableList
internal PrivateArrayList

private field storage :: Array = Array()
private field currentSize :: Integer = 0

// This field tracks how many structural modifications the list has undergone. Changing an element
// is not a structural modification, but adding or removing an element is.
private field version :: Integer = 0

override method iterate(): ArrayListIterator(this)

override property size: currentSize

override method get(index):
checkIndex("List.get", index)
storage[index]

override method sublist(start, end):
checkSublistIndicies("List.sublist", start, end)
ArraySublist(this, start, end)

override method set(index, element):
checkIndex("List.set", index)
storage[index] := element

override method add(element):
version := version + 1
ensureCapacity(currentSize + 1)
storage[currentSize] := element
currentSize := currentSize + 1
version := version + 1

override method remove(element):
let i = find(element)
unless i == -1 | delete(i)

override method insert(index :: Integer, element) :: Void:
checkInsertionIndex("List.insert", index)
ensureCapacity(currentSize + 1)
fun loop(i = currentSize):
unless i == index
| storage[i] := storage[i - 1]
loop(i - 1)
loop()
storage[index] := element
currentSize := currentSize + 1
version := version + 1

override method delete(index :: Integer) :: Void:
checkIndex("List.delete", index)
for:
each i: index + 1 .. currentSize
storage[i - 1] := storage[i]
storage[currentSize - 1] := #false
currentSize := currentSize - 1
version := version + 1

override method clear() :: Void:
storage := Array()
currentSize := 0
version := version + 1

private method find(element):
fun loop(i = 0):
cond
| i == currentSize: -1
| storage[i] == element: i
| ~else: loop(i + 1)
loop()

method ensureCapacity(requiredSize) :: Void:
when storage.length() < requiredSize
| let newStorage = Array.make(max(storage.length() * 2, requiredSize))
for:
each:
v: storage
i: 0..
newStorage[i] := v
storage := newStorage


class ArraySublist(backingList :: PrivateArrayList, start :: Integer, mutable end :: Integer):
implements MutableList

override method iterate():
ArraySublistIterator(this)

override property size:
end - start

override method contains(element):
find(element) != -1

override method get(index):
checkIndex("List.get", index)
backingList.get(index + start)

override method sublist(start, end):
checkSublistIndicies("List.sublist", start, end)
ArraySublist(backingList, this.start + start, this.start + end)

override method set(index, element):
checkIndex("List.set", index)
backingList.set(index + start, element)

override method add(element):
backingList.insert(end, element)

override method remove(element):
let i = find(element)
unless i == -1
| delete(i)

override method insert(index, element):
checkInsertionIndex("List.insert", index)
backingList.insert(index + start, element)
end := end + 1

override method delete(index):
checkIndex("List.delete", index)
backingList.delete(index + start)
end := end - 1

override method clear():
let elementsToShift = backingList.currentSize - end
let currentSize = size
for:
each i: start .. start + elementsToShift
backingList.storage[i] := backingList.storage[i + currentSize]
let newSize = backingList.size - currentSize
for:
each i: newSize .. backingList.currentSize
backingList.storage[i] := #false
backingList.currentSize := newSize
backingList.version := backingList.version + 1
end := 0

private method find(element):
fun loop(i = start):
cond
| i == end: -1
| backingList.get(i) == element: i - start
| ~else: loop(i + 1)
loop()


class ArrayListIterator(backingList :: ArrayList, private version :: Integer = backingList.version):
implements Iterator

private field index :: Integer: 0

override method hasNext():
when version < backingList.version | error("concurrent modification")
index < backingList.size

override method next():
when version < backingList.version | error("concurrent modification")
unless index < backingList.size | error("no such element")
let element = backingList.get(index)
index := index + 1
element


// TODO
class ArraySublistIterator(backingSublist :: ArraySublist)


fun max(x, y):
if x < y | y | x
84 changes: 84 additions & 0 deletions rhombus/data/private/list.rhm
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
#lang rhombus


export:
List
ListView
MutableList


import:
rhombus/data/collection.Collection
rhombus/data/collection.CollectionView
rhombus/data/collection.MutableCollection
rhombus/private/precondition.checkArgument


interface ListView:
extends CollectionView

method get(index :: Integer)
method sublist(start :: Integer, end :: Integer) :: ListView

method checkIndex(who, index):
checkArgument(
who,
index >= 0 && index < size,
"index out of bounds",
"index", index,
"size", size)

method checkInsertionIndex(who, index):
checkArgument(
who,
index >= 0 && index <= size,
"index out of bounds",
"index", index,
"size", size)

method checkSublistIndicies(who, start, end):
checkArgument(
who,
start >= 0 && start <= size,
"sublist start index out of bounds",
"start index", start,
"end index", end,
"size", size)
checkArgument(
who,
end >= 0 && end <= size,
"sublist end index out of bounds",
"start index", start,
"end index", end,
"size", size)
checkArgument(
who,
start <= end,
"sublist start index occurs after end index",
"start index", start,
"end index", end,
"size", size)


interface List:
extends:
ListView
Collection

method set(index :: Integer, element) :: List
override add(element) :: List
override remove(element) :: List
method insert(index :: Integer, element) :: List
method delete(index :: Integer) :: List
override sublist(start :: Integer, end :: Integer) :: List


interface MutableList:
extends:
ListView
MutableCollection

method set(index :: Integer, element) :: Void
method insert(index :: Integer, element) :: Void
method delete(index :: Integer) :: Void
override sublist(start :: Integer, end :: Integer) :: MutableList
37 changes: 37 additions & 0 deletions rhombus/data/private/list_builder.rhm
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
#lang rhombus


export:
ListBuilder


import:
rhombus/data/private/array_list.ArrayList
rhombus/data/private/regular_immutable_list.RegularImmutableList
rhombus/data/private/small_lists.SingletonList
rhombus/data/private/small_lists.EmptyList


class ListBuilder():

private field storage :: ArrayList = ArrayList()

method add(element):
storage.add(element)
this

method addAll(elements):
storage.addAll(elements)
this

method build():
match storage.size
| 0: EmptyList()
| 1: SingletonList(storage.get(0))
| n:
let copy = Array.make(n)
for:
each:
i: 0..n
copy[i] := storage.get(i)
RegularImmutableList(copy)
11 changes: 11 additions & 0 deletions rhombus/data/private/persistent_list.rhm
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#lang rhombus


export:
PersistentList


class PersistentList()
class PersistentSublist()
class PersistentListIterator()
class PersistentSublistIterator()
Loading