-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unicode lambda #1374
base: master
Are you sure you want to change the base?
Unicode lambda #1374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should add/change anything to legacy or compatibility libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should add/change anything to legacy or compatibility libraries.
If this file is not modified, an error will be reported (I forgot to record the specific error message).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/usr/share/racket/pkgs/typed-racket-compatibility/typed/scheme/base.rkt:20:22: module: identifier already required
at: case-λ
in: typed-racket/base-env/prims
also provided by: scheme/base
compilation context...:
/usr/share/racket/pkgs/typed-racket-compatibility/typed/scheme/base.rkt
location...:
/usr/share/racket/pkgs/typed-racket-compatibility/typed/scheme/base.rkt:20:22
context...:
/usr/share/racket/collects/compiler/private/cm-minimal.rkt:700:0: compile-zo*
/usr/share/racket/collects/compiler/private/cm-minimal.rkt:633:0: compile-zo*/cross-compile
/usr/share/racket/collects/compiler/private/cm-minimal.rkt:449:15
/usr/share/racket/collects/compiler/private/cm-minimal.rkt:435:12: build
/usr/share/racket/collects/compiler/private/cm-minimal.rkt:406:0: maybe-compile-zo
/usr/share/racket/collects/compiler/private/cm-minimal.rkt:210:0: compile-root
/usr/share/racket/collects/compiler/private/cm-minimal.rkt:317:16
/usr/share/racket/collects/compiler/private/cm-util.rkt:14:0: ormap-strict
[repeats 4 more times]
/usr/share/racket/collects/compiler/private/cm-minimal.rkt:210:0: compile-root
/usr/share/racket/collects/compiler/private/cm-minimal.rkt:317:16
/usr/share/racket/collects/compiler/private/cm-util.rkt:14:0: ormap-strict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I read the wrong file in the reply, sorry!
@NoahStoryM do you still want to work on this? It appears there's an error in the latest commit. |
Sorry, I just saw this reply now. I think the error is because it was tested with old version Racket ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resyntax analyzed 2 files in this pull request and found no issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resyntax analyzed 2 files in this pull request and found no issues.
@sorawee This PR has been open for a while, could you consider merging it? |
I think @samth would be a good reviewer for this PR. |
Checklist
Description of change
Add
case-λ
,.case-λ:
,pcase-λ:
,pλ:
,λ:
,popt-λ:
,opt-λ: