Automated Resyntax fixes #1391
Closed
Automated Resyntax fixes #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
This is an automated change generated by Resyntax. #### Pass 1 Applied 2 fixes to [`typed-racket-lib/typed-racket/rep/prop-rep.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/rep/prop-rep.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 146, `sort-with-keyed-comparator-to-sort-by-key`: This `sort` expression can be replaced with a simpler, equivalent expression. Applied 2 fixes to [`typed-racket-lib/typed-racket/types/match-expanders.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/types/match-expanders.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 78, `define-simple-macro-to-define-syntax-parse-rule`: The `define-simple-macro` form has been renamed to `define-syntax-parse-rule`. Applied 1 fix to [`typed-racket-lib/typed-racket/typecheck/tc-app/utils.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/typecheck/tc-app/utils.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. ## Summary Fixed 5 issues in 3 files. * Fixed 3 occurrences of `tidy-require` * Fixed 1 occurrence of `sort-with-keyed-comparator-to-sort-by-key` * Fixed 1 occurrence of `define-simple-macro-to-define-syntax-parse-rule`
jackfirth
reviewed
Sep 20, 2024
Comment on lines
+3
to
+12
| (require racket/lazy-require | ||
| racket/match | ||
| (contract-req) | ||
| (only-in racket/unsafe/ops unsafe-fx<=) | ||
| "../utils/utils.rkt" | ||
| "core-rep.rkt" | ||
| "fme-utils.rkt" | ||
| "rep-utils.rkt" | ||
| "free-variance.rkt" | ||
| "core-rep.rkt" | ||
| "object-rep.rkt" | ||
| racket/match | ||
| racket/lazy-require | ||
| (only-in racket/unsafe/ops unsafe-fx<=)) | ||
| "rep-utils.rkt") |
There was a problem hiding this comment.
This change is busted, see jackfirth/resyntax#316
jackfirth
reviewed
Sep 20, 2024
Comment on lines
+81
to
+90
| [(Mu-unsafe: (Union: (== -Null) (list (pair-matcher elem-t (B: 0))))) | ||
| (define elem-t* (instantiate-type elem-t t)) | ||
| (cond | ||
| [simple? (and (equal? elem-t elem-t*) elem-t)] | ||
| [else elem-t*])] | ||
| [(Union: (== -Null) (list (pair-matcher hd-t tl-t))) | ||
| (cond | ||
| [(listof-pred? tl-t) | ||
| => (λ (lst-t) (and (equal? hd-t lst-t) hd-t))] | ||
| => | ||
| (λ (lst-t) (and (equal? hd-t lst-t) hd-t))] |
There was a problem hiding this comment.
The define-simple-macro migration rule shouldn't have bothered with these formatting changes. Filed jackfirth/resyntax#317.
|
I'm closing this one because it didn't meet my quality standards. For details, see the linked Resyntax issues above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated change generated by Resyntax.
Pass 1
Applied 2 fixes to
typed-racket-lib/typed-racket/rep/prop-rep.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.sort-with-keyed-comparator-to-sort-by-key: Thissortexpression can be replaced with a simpler, equivalent expression.Applied 2 fixes to
typed-racket-lib/typed-racket/types/match-expanders.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.define-simple-macro-to-define-syntax-parse-rule: Thedefine-simple-macroform has been renamed todefine-syntax-parse-rule.Applied 1 fix to
typed-racket-lib/typed-racket/typecheck/tc-app/utils.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Summary
Fixed 5 issues in 3 files.
tidy-requiresort-with-keyed-comparator-to-sort-by-keydefine-simple-macro-to-define-syntax-parse-rule