Automated Resyntax fixes #1417
Merged
Automated Resyntax fixes #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
Keep imports in `require` sorted and grouped by phase, with collections before files.
This `match` expression can be simplified using `match-define`.
This use of `define-values` is unnecessary.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `sort` expression can be replaced with a simpler, equivalent expression.
These nested `for` loops can be replaced by a single `for*` loop.
This `let` expression can be pulled up into a `define` expression.
Use the `#:unless` keyword instead of `unless` to reduce loop body indentation.
The `define` form supports a shorthand for defining functions.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
|
Those weird warnings seem to be coming from here. Not sure why that file is printing out warnings at |
jackfirth
added a commit
to jackfirth/resyntax
that referenced
this pull request
Dec 6, 2024
This should keep it out of Autofixer pull request descriptions, as observed in racket/typed-racket#1417.
jackfirth
added a commit
to jackfirth/resyntax
that referenced
this pull request
Dec 6, 2024
This should keep it out of Autofixer pull request descriptions, as observed in racket/typed-racket#1417.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: Missing test for base type 'Positive-Single-Flonum'
WARNING: Missing test for base type '∪'
WARNING: Missing test for base type 'Single-Flonum'
WARNING: Missing test for base type 'Intersection'
WARNING: Missing test for base type 'Inexact-Imaginary'
WARNING: Missing test for base type 'Single-Flonum-Complex'
WARNING: Missing test for base type 'Union'
WARNING: Missing test for base type 'Single-Flonum-Zero'
WARNING: Missing test for base type 'ExtFlVector'
WARNING: Missing test for base type '∩'
WARNING: Missing test for base type 'ExtFlonum-Positive-Zero'
WARNING: Missing test for base type 'Nonpositive-ExtFlonum'
WARNING: Missing test for base type 'Place'
WARNING: Missing test for base type 'U'
WARNING: Missing test for base type 'ExtFlonum-Zero'
WARNING: Missing test for base type 'Internal-Definition-Context'
WARNING: Missing test for base type 'Read-Table'
WARNING: Missing test for base type 'Un'
WARNING: Missing test for base type 'Negative-Single-Flonum'
WARNING: Missing test for base type 'Unquoted-Printing-String'
WARNING: Missing test for base type 'Negative-ExtFlonum'
WARNING: Missing test for base type 'Single-Flonum-Negative-Zero'
WARNING: Missing test for base type 'Single-Flonum-Positive-Zero'
WARNING: Missing test for base type 'ExtFlonum'
WARNING: Missing test for base type 'Nonnegative-Single-Flonum'
WARNING: Missing test for base type 'ExtFlonum-Nan'
WARNING: Missing test for base type 'ExtFlonum-Negative-Zero'
WARNING: Missing test for base type 'Single-Flonum-Nan'
WARNING: Missing test for base type 'Positive-ExtFlonum'
WARNING: Missing test for base type 'Nonnegative-ExtFlonum'
WARNING: Missing test for base type 'Nonpositive-Single-Flonum'
Resyntax fixed 40 issues in 20 files.
single-clause-match-to-match-definetidy-requirelet-to-definedefine-let-to-double-definenested-for-to-for*define-lambda-to-defineunless-expression-in-for-loop-to-unless-keyworddefine-values-values-to-definesort-with-keyed-comparator-to-sort-by-key