Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename contracts in tests #850

Merged
merged 4 commits into from
Aug 25, 2019
Merged

rename contracts in tests #850

merged 4 commits into from
Aug 25, 2019

Conversation

bennn
Copy link
Contributor

@bennn bennn commented Aug 24, 2019

Change the names in check-exns to match the new names from cb0fb44

Test failures now come with a "location" field that reports the line of
the failed test.
Fix test failures introduced by renaming flat contracts in commit cb0fb44
@bennn
Copy link
Contributor Author

bennn commented Aug 24, 2019

The latest build should not have passed; there are errors in https://travis-ci.org/racket/typed-racket/jobs/576236718

Maybe the allow_failures needs to change?
https://stackoverflow.com/questions/20905969/travisci-how-to-allow-failures-for-environment-variable

EDIT: the next build shows 2 categories --- normal jobs & allowed failures --- but there are still error messages in a normal job

EDIT2: well okay, the passing tests are due to racket/rackunit#98 (EDIT3 no I'm not sure about that)

EDIT4: the latest tests finished cleanly --- no error output besides the Struct-Property docs

@bennn bennn merged commit 725d10e into racket:master Aug 25, 2019
@bennn bennn deleted the travis branch August 25, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant