Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to disable RacksDB #434

Merged
merged 20 commits into from
Jan 10, 2025
Merged

Add possibility to disable RacksDB #434

merged 20 commits into from
Jan 10, 2025

Conversation

rezib
Copy link
Contributor

@rezib rezib commented Jan 6, 2025

Pending tasks before consider merging:

  • Update quickstart guide to mention RacksDB is now optional
  • Add unit tests to cover ResourcesView (with and without RacksDB)
  • Do not check version of RacksDB provided by the agent when RacksDB is disabled on this agent.

fix #418

@rezib rezib marked this pull request as draft January 6, 2025 17:45
@rezib rezib self-assigned this Jan 6, 2025
@rezib rezib added the feature New feature or enhancement to develop. label Jan 6, 2025
@rezib rezib added this to the v4.1.0 milestone Jan 6, 2025
@rezib rezib marked this pull request as ready for review January 9, 2025 20:37
rezib added 18 commits January 9, 2025 21:48
Reduce height of error message container when unable to retrieve
infrastructure graphical representation from RacksDB in resources page.
Do not show fullscreen button on error message container when unable to
retrieve infrastructure graphical representation from RacksDB.
Restore infrastructure graphical representation canvas on cluster change
in resources page when coming from cluster on which RacksDB failed.
Add racksdb > enabled parameter for the agent to control if RacksDB
integration for infrastructure advanced visualization feature is enabled
on a cluster.
Return RacksDB enabled boolean as defined in agent configuration in
/info endpoint.
Return RacksDB enabled boolean feature flag of every clusters in
/clusters endpoint.
Do not display infrastructure advanced graphical representation canvas
in resources page when RacksDB is disabled in agent configuration for a
cluster.

fix #418
Move generic get/post methods with token authentication and error
management in new composable. This notably simplifies unit testing of
GatewayAPI composable.
In Node JS, FormData.get() returns a File object instance when the part
is a file. This File is converted to a Blob so it can be loaded in
canvas. This is required to run this code in unit tests with Node JS and
it doesn't hurt browsers which don't need this additional conversion.
Turn loading ref from HTMLSpanElement to boolean. This is used to
defined v-show on loading spinner and resources diagram canvas.
Explain RacksDB is now optional in quickstart guide, with method to
disable integration feature in side note, and in overview and
architecture pages.
@rezib
Copy link
Contributor Author

rezib commented Jan 10, 2025

Do not check version of RacksDB provided by the agent when RacksDB is disabled on this agent.

rezib added 2 commits January 10, 2025 17:10
Do not check for supported version of RacksDB on agent when it is
actually disabled on this agent.
@rezib rezib changed the title Add possibility to disabled RacksDB Add possibility to disable RacksDB Jan 10, 2025
@rezib rezib merged commit 4aa1692 into main Jan 10, 2025
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or enhancement to develop.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to disable RacksDB
1 participant