add trackVerifiedToken() #270

nickpatrick · 2023-08-16T14:21:04Z

No description provided.

Example/Example/AppDelegate.swift

RadarSDK/RadarUtils.m

lmeier · 2023-08-16T14:30:15Z

RadarSDK/RadarAPIClient.m

+                        if (encrypted) {
+                            if (!tokenObj) {
+                                return completionHandler(status, nil, nil, nil, nil, nil, nil);
+                            }
+
+                            NSString *token = (NSString *)tokenObj;
+
+                            return completionHandler(status, nil, nil, nil, nil, nil, token);
+                        }


This codepath is completely forgoing updating the event & location update handlers, trips, & place updating.

As such, trackVerified and trackVerifiedEncrypted behave significantly differently -- wonder how we should make it clear to users the difference in behavior and effects (could see myself getting confused by this).

Will mention on /documentation. Most people using this aren't going to be using startTracking(), so shouldn't cause unexpected behavior in practice

jsani-radar

looking good overall - few small things

jsani-radar · 2023-08-16T14:48:46Z

Example/Example/AppDelegate.swift

        Radar.setDelegate(self)
+
+        Radar.trackVerified { status, location, events, user in
+


nit: print result?

I ran into a weird issue with this:

Radar.trackVerifiedEncrypted{ ( status, token ) in NSLog("Got token:") NSLog(token!) }

The token printed was truncated to 1,024 characters, but the token returned from the server was 7,000+ characters.

While running the debugger, and clicking Copy, would sometimes copy the truncated value, but not always:

I had to run print (void)CFShow(token) in the debugging console to show the entire token to confirm it was being captured.

I ran into a similar issue testing on Android where logcat lines seem to be truncated to 4000 chars, but my token was something like 4300. I just printed it in two parts. In any case, I reverted this. We can revisit inclusion in sample app when we revisit sample app code more broadly

jsani-radar · 2023-08-16T14:50:20Z

RadarSDK/Include/Radar.h

+
+ Receives the request status and, if successful, a JSON Web Token (JWT) containing an array of the events generated and the user. Decrypt the JWT server-side using your private key.
+
+ @see https://radar.com/documentation/sdk/ios


should we be pointing to the iOS docs or fraud docs? comments above the callback and method are inconsistent at the moment

Good catch, will update

jsani-radar · 2023-08-16T14:55:42Z

RadarSDK/Radar.m

@@ -219,7 +219,7 @@ + (void)trackOnceWithLocation:(CLLocation *)location completionHandler:(RadarTra
                                              replayed:NO
                                               beacons:nil


is there a use case where a customer would want the payload encrypted through the vanilla trackOnce call and not necessarily need SSL pinning? wondering if we should add an encrypted option here too

I don't think there is, I think if they want the encrypted payload they have to do the full trackVerified experience.

jsani-radar · 2023-08-16T14:57:06Z

RadarSDK/Radar.m

@@ -219,7 +219,7 @@ + (void)trackOnceWithLocation:(CLLocation *)location completionHandler:(RadarTra
                                              replayed:NO
                                               beacons:nil
                                     completionHandler:^(RadarStatus status, NSDictionary *_Nullable res, NSArray<RadarEvent *> *_Nullable events, RadarUser *_Nullable user,
-                                                         NSArray<RadarGeofence *> *_Nullable nearbyGeofences, RadarConfig *_Nullable config) {
+                                                         NSArray<RadarGeofence *> *_Nullable nearbyGeofences, RadarConfig *_Nullable config, NSString *_Nullable token) {


do we call out anywhere that the rest of the objects in this callback will be nil if token is present?

This callback is only ever used internally, not worried about it

lmeier · 2023-08-16T15:06:17Z

RadarSDK/RadarUtils.m

+    NSString *testPath = @"/private/JailbreakTest.txt";
+    NSData *data = [@"This is a test." dataUsingEncoding:NSUTF8StringEncoding];
+
+    NSError *error;
+    [data writeToFile:testPath options:NSDataWritingAtomic error:&error];
+
+    // If no error occurred, the device is likely jailbroken
+    if (!error) {
+        NSLog(@"failed check 2");
+        [[NSFileManager defaultManager] removeItemAtPath:testPath error:nil];
+        return YES;
+    }


The first test makes sense to me.

For this test here, I'd love to read up on why this test works — is there a SO or other resource you can point me to?

This doesn't actually work, reverting

lmeier · 2023-08-22T00:24:08Z

RadarSDK/RadarAPIClient.h

@@ -86,6 +87,7 @@ typedef void (^_Nonnull RadarSyncLogsAPICompletionHandler)(RadarStatus status);
        attestationString:(NSString *_Nullable)attestationString
                    keyId:(NSString *_Nullable)keyId
         attestationError:(NSString *_Nullable)attestationError
+                encrypted:(BOOL)encrypted


was going to suggest we think about changing this to verified given discussion in slack & recent changes, but of course that's already used.. 🤔

Looking at the JWT docs, I think encoded instead of encrypted would perhaps be most accurate

Thinking we can change param or endpoint name or switch to a project setting later on

token param or POST /track/token endpoint are both options, too

* First part of offline replay * Fix kotlin errors * Fix params for replays * Extend timeout * Fix unallocated val bug * Fix nowMS bug * Fix connectTimeout numbers * Bump version to 3.5.12-beta.2 to cut a prerelease * Bump nexus client timeout * Fix bugs in buffer logic * bump version to 3.5.11-beta.6

* publish SNAPSHOT releases from pre-releases not from pushing to develop (#259) * don't publish pre-releases to maven as a release * publish SNAPSHOTs from pre-releases not from pushing to develop * MOB-57: update the README with more detail on example app (#260) Co-authored-by: Jason R Tibbetts <[email protected]> Co-authored-by: Nick Patrick <[email protected]> Co-authored-by: Tim Julien <[email protected]> * Surface center, radius, and location for geofences & places (#267) * Surface center, radius, and location for geofences & places * rely on geofence's geometry for center and radius, add test * RAD-5747 Anonymous config call in `trackOnce` (#266) * add config call for anonymous before track * add boolean for track usage * usage enum not bool * resume usage * move config track usage call later in the call stack * move config track usage call later in the call stack * use anon val * bump version * 3.5.11 version bump --------- Co-authored-by: Jason R Tibbetts <[email protected]> Co-authored-by: Nick Patrick <[email protected]> Co-authored-by: Tim Julien <[email protected]> * Include approachingThreshold in tripOptions (#261) * Include approachingThreshold in trip options helper functions * Only include in dictionary if > 0, add test * Offline replay (#270) * First part of offline replay * Fix kotlin errors * Fix params for replays * Extend timeout * Fix unallocated val bug * Fix nowMS bug * Fix connectTimeout numbers * Bump version to 3.5.12-beta.2 to cut a prerelease * Bump nexus client timeout * Fix bugs in buffer logic * bump version to 3.5.11-beta.6 * dont fire event listeners for custom events (#263) * publish beta's the same way we publish final releases (#273) * publish beta's the same way we publish final releases * Delete radar-snapshot-action.yml * Update build.gradle * Always clear last location if successful track (#272) * Always clear last location if succesful track * Always use System.currentTimeMillis() * Always clear ReplayBuffer upon successful request --------- Co-authored-by: Tim Julien <[email protected]> * version bump * set replay = NONE for continuous * not beta anymore --------- Co-authored-by: Travis Derouin <[email protected]> Co-authored-by: Jason R Tibbetts <[email protected]> Co-authored-by: Nick Patrick <[email protected]> Co-authored-by: Liam Meier <[email protected]> Co-authored-by: David Goodfellow <[email protected]> Co-authored-by: jsani-radar <[email protected]>

add trackVerifiedEncrypted()

eb135b1

nickpatrick requested review from tjulien, tderouin, corypisano, lmeier and jsani-radar August 16, 2023 14:21

nickpatrick commented Aug 16, 2023

View reviewed changes

Example/Example/AppDelegate.swift Outdated Show resolved Hide resolved

nickpatrick commented Aug 16, 2023

View reviewed changes

RadarSDK/RadarUtils.m Outdated Show resolved Hide resolved

lmeier reviewed Aug 16, 2023

View reviewed changes

jsani-radar reviewed Aug 16, 2023

View reviewed changes

lmeier reviewed Aug 16, 2023

View reviewed changes

rename to trackVerifiedToken(), revert sample app code

be700de

nickpatrick changed the title ~~add trackVerifiedEncrypted()~~ add trackVerifiedToken() Aug 21, 2023

remove checks

15258c6

nickpatrick marked this pull request as ready for review August 21, 2023 22:13

nickpatrick added 2 commits August 21, 2023 18:14

fix docs

4753a69

revert includes

085453f

lmeier reviewed Aug 22, 2023

View reviewed changes

nickpatrick added 2 commits August 22, 2023 06:00

bump version

6ce4f43

Merge branch 'master' into track-verified-encrypted

4fd1f21

nickpatrick merged commit f9c70e4 into master Aug 22, 2023
1 check passed

nickpatrick deleted the track-verified-encrypted branch August 22, 2023 10:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add trackVerifiedToken() #270

add trackVerifiedToken() #270

nickpatrick commented Aug 16, 2023

lmeier Aug 16, 2023

nickpatrick Aug 21, 2023 •

edited

Loading

jsani-radar left a comment

jsani-radar Aug 16, 2023

tderouin Aug 16, 2023

nickpatrick Aug 21, 2023

jsani-radar Aug 16, 2023

nickpatrick Aug 21, 2023

jsani-radar Aug 16, 2023

tderouin Aug 16, 2023

jsani-radar Aug 16, 2023

nickpatrick Aug 21, 2023 •

edited

Loading

lmeier Aug 16, 2023

nickpatrick Aug 21, 2023

lmeier Aug 22, 2023

lmeier Aug 22, 2023 •

edited

Loading

nickpatrick Aug 22, 2023

nickpatrick Aug 22, 2023

		Radar.setDelegate(self)

		Radar.trackVerified { status, location, events, user in


		Receives the request status and, if successful, a JSON Web Token (JWT) containing an array of the events generated and the user. Decrypt the JWT server-side using your private key.

		@see https://radar.com/documentation/sdk/ios

		@@ -219,7 +219,7 @@ + (void)trackOnceWithLocation:(CLLocation *)location completionHandler:(RadarTra
		replayed:NO
		beacons:nil

add trackVerifiedToken() #270

add trackVerifiedToken() #270

Conversation

nickpatrick commented Aug 16, 2023

Choose a reason for hiding this comment

nickpatrick Aug 21, 2023 • edited Loading

Choose a reason for hiding this comment

jsani-radar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickpatrick Aug 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lmeier Aug 22, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickpatrick Aug 21, 2023 •

edited

Loading

nickpatrick Aug 21, 2023 •

edited

Loading

lmeier Aug 22, 2023 •

edited

Loading