Liammeier/fence 1220 flush replays in more sdk lifecycle methods ios #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corypisano
reviewed
Aug 31, 2023
RadarSDK/RadarAPIClient.m
Outdated
| [RadarSettings updateLastTrackedTime]; | ||
| } | ||
|
|
||
| [[RadarDelegateHolder sharedInstance] didFailWithStatus:status]; |
There was a problem hiding this comment.
Should just need the one didFailWithStatus from above in if (status != RadarStatusSuccess)
There was a problem hiding this comment.
nice catch. we do need just one, but this is the one we should keep actually.
current behavior is that even if RadarStatusSuccess, we fall through to [[RadarDelegateHolder sharedInstance] didFailWithStatus:status]; when calling /track/replay
There was a problem hiding this comment.
hm is that current behavior intentional though? Seemed like that was the "Radar error received" logs even though no error
There was a problem hiding this comment.
Ok, I actually figured out how to get toolkit working here while making this behave in a more standard manner. a44b46e
corypisano
approved these changes
Sep 5, 2023
lmeier
deleted the
liammeier/fence-1220-flush-replays-in-more-sdk-lifecycle-methods-ios
branch
ShiCheng-Lu
pushed a commit
that referenced
this pull request
Jun 13, 2024
…app-opens-by-default CORE-292 log app opens by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.