Add rto tracking options update to trackOnce and trackVerified calls #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmeier
reviewed
Oct 10, 2023
RadarSDK/Radar.m
Outdated
| @@ -161,6 +161,7 @@ + (void)trackOnceWithDesiredAccuracy:(RadarTrackingOptionsDesiredAccuracy)desire | |||
| NSArray<RadarGeofence *> *_Nullable nearbyGeofences, RadarConfig *_Nullable config, NSString *_Nullable token) { | |||
| if (status == RadarStatusSuccess) { | |||
| [[RadarLocationManager sharedInstance] replaceSyncedGeofences:nearbyGeofences]; | |||
| [[RadarLocationManager sharedInstance] updateTrackingFromMeta:config.meta]; | |||
There was a problem hiding this comment.
This config is nullable so we should check that exists before accessing config.meta
lmeier
requested changes
Oct 10, 2023
lmeier
reviewed
Oct 11, 2023
| @@ -161,6 +161,10 @@ + (void)trackOnceWithDesiredAccuracy:(RadarTrackingOptionsDesiredAccuracy)desire | |||
| NSArray<RadarGeofence *> *_Nullable nearbyGeofences, RadarConfig *_Nullable config, NSString *_Nullable token) { | |||
| if (status == RadarStatusSuccess) { | |||
| [[RadarLocationManager sharedInstance] replaceSyncedGeofences:nearbyGeofences]; | |||
| if(config != nil){ | |||
There was a problem hiding this comment.
text formatting is off here, see line 162 for correct spacing
lmeier
reviewed
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously only updated the RTO settings with background tracking calls, this PR adds a side-effect to the
trackOnceandtrackVerifiedcalls such that any updates to RTO tracking options are saved into settings.QA:
steps:
Follow up question, do we wish to introduce this side effect to the track verified calls and the mock tracking calls too?