App lifecycle logging & log persistence #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmeier
reviewed
Dec 6, 2023
lmeier
reviewed
Dec 6, 2023
RadarSDK/RadarFileSystem.m
Outdated
There was a problem hiding this comment.
think RadarFileStorage is probably better naming than RadarFileSystem
lmeier
reviewed
Jan 2, 2024
RadarSDK/RadarLogBuffer.m
Outdated
| } | ||
| } | ||
|
|
||
| //for use in testing |
There was a problem hiding this comment.
Comments describing functions follow the format:
/**
* Return copy of replays in buffer
*/
lmeier
reviewed
Jan 2, 2024
RadarSDK/RadarLogBuffer.m
Outdated
| [self write:level type:type message:message forcePersist:NO]; | ||
| } | ||
|
|
||
| - (void)write:(RadarLogLevel)level type:(RadarLogType)type message:(NSString *)message forcePersist:(BOOL)forcePersist{ |
lmeier
reviewed
Jan 3, 2024
RadarSDK/RadarLogBuffer.m
Outdated
| [self writeToFileStorage:flushableLogs]; | ||
| [self purgeOldestLogs]; | ||
| [inMemoryLogBuffer removeAllObjects]; | ||
| if([inMemoryLogBuffer count] > 0) { |
|
https://expo.dev/accounts/radarlabs/projects/waypoint/builds/674c5efa-1ff1-4de9-beb1-61622404631e In addition to the change of names, we have also decided to not have expose the logging methods via RN, this waypoint build reflects that. |
lmeier
approved these changes
Jan 4, 2024
ShiCheng-Lu
pushed a commit
that referenced
this pull request
Jun 13, 2024
* comment out opened_app * change numbering on migration guides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to replace the purely in-memory log buffer with a persistent buffer on disk.
RadarFileClassis as simple wrapper for file I/O operations, it can delete files, read files, replace or append data in files.RadarLogis extended to be serialized into string JSONs and back.RadarLoggeris extended to append time and battery information behind some logs.RadarLogBufferis modified and extended to write new logs a in memory buffer that is flushed into disk periodically and when the app is backgrounded. The logs on disk are then read and flushed to the dashboard, similar to the old memory buffer. We also allow for quick appending of logs which is needed when IOS limits the time and resources the SDK has (when backgrounding and terminating the app).QA:
Unit tests are included for
RadarFileClassandRadarLogBufferWaypoint build: https://expo.dev/accounts/radarlabs/projects/waypoint/builds/168fb1ba-3517-4036-9fff-811e23f77a37
was able to flush logs as expected to dashboard: