Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trackVerifiedToken() #119

Merged
merged 4 commits into from
Aug 23, 2023
Merged

add trackVerifiedToken() #119

merged 4 commits into from
Aug 23, 2023

Conversation

nickpatrick
Copy link
Contributor

@nickpatrick nickpatrick commented Aug 21, 2023

  • exposes Radar.trackVerifiedToken()
  • adds a new demo page
image

@nickpatrick nickpatrick changed the base branch from master to radar-verify August 21, 2023 22:31
Base automatically changed from radar-verify to master August 21, 2023 22:56
@nickpatrick nickpatrick marked this pull request as ready for review August 22, 2023 10:46
</div>
</div>

<div class="mt-4">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably omit the code samples on these. These should probably live in the docs (I only added them as a temporary solution until we go the UI kits in the docs).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've actually found it helpful to be able to show the code sample when using this page in demos (which I'm doing a lot), but we can always remove later

}

return trackTokenRes;
} else {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically don't need this else since it returns above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

kochis
kochis previously approved these changes Aug 22, 2023
@nickpatrick nickpatrick merged commit 2627fa4 into master Aug 23, 2023
2 checks passed
@nickpatrick nickpatrick deleted the track-verified-token branch August 23, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants