Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker click event #154

Closed
wants to merge 0 commits into from
Closed

Marker click event #154

wants to merge 0 commits into from

Conversation

jaspk06
Copy link
Contributor

@jaspk06 jaspk06 commented Apr 10, 2024

NOTE: #153 needs to be reviewed first

  • adds a 'click' event to RadarMarker. This is useful for attaching event listeners to the marker

@jaspk06 jaspk06 changed the base branch from master to refactor-map-ui April 10, 2024 21:13
@jaspk06 jaspk06 mentioned this pull request May 6, 2024
@jaspk06 jaspk06 requested a review from kochis May 6, 2024 14:49
@@ -64,6 +64,20 @@ class RadarMarker extends maplibregl.Marker {
return super.remove();
}

_onMapClick(e: maplibregl.MapMouseEvent): void {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an inherited function / how is this called?

@jaspk06 jaspk06 force-pushed the marker-click-event branch from f49403d to 25bbead Compare May 16, 2024 15:39
@jaspk06 jaspk06 changed the base branch from refactor-map-ui to release-4.3 May 16, 2024 15:39
@jaspk06 jaspk06 closed this May 16, 2024
@jaspk06 jaspk06 force-pushed the marker-click-event branch from 25bbead to f804d3f Compare May 16, 2024 15:40
@jaspk06 jaspk06 mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants