save user._id to storage after track, and use in conversion event #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmeier
reviewed
Nov 18, 2024
There was a problem hiding this comment.
Should also send _id up in track if it exists (makes subsequent tracks more performant).
kochis
reviewed
Nov 19, 2024
| const deviceId = params.deviceId || Device.getDeviceId(); | ||
| const installId = params.installId || Device.getInstallId(); | ||
| const sessionId = Session.getSessionId(); | ||
| const locationAuthorization = await Navigator.getPermissionStatus(); | ||
|
|
||
| const data = { | ||
| const data: any = { | ||
| id, |
There was a problem hiding this comment.
Just to verify, id is the correct param (not _id)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save
user._idfromtrackresult to be used in conversion event. Which is the current behavior of mobile sdks.It doesn't look like the userId takes priority over the deviceId/installId, so if there is a mismatch, it still logs to the user associated with
deviceId/installId.So I concluded that this endpoint is not meant to be able to log a conversion for a different user than the current logged in user.
Which means that if we do have an
_id, there is no reason not to use it.(originally, I had it where it only uses _id if none of the other parameters are provided, or is the same as the saved value, but this is not necessary if the conversion call should only post event for the current user).
Tested with the demo app:
idbeing populated in the POST event API call, and event is logged in dashboard.