WIN32: the nfds parameter of select() is unused. #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, though there are 2 issues:
|
Winsock provides an opaque SOCKET type for handling sockets and the nfds parameter of select() is ignored but kept for compatibity with BSD standard. Expecting to handle sockets by not assuming to be an int type, this could cause a complain from MSVC when compiling for 64bit for Windows because incompatible types, so it would be better to just ignore this and just leave nfds to zero.
carlo-bramini
force-pushed
the
fix_windows_2
branch
from
c6fc90d to
7c0492c
Compare
|
I did the changes that you suggested to me, thank you. |
|
Yes, we still need to work on the macOS CI 😁 Thanks for fixing, I will merge that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Winsock provides an opaque
SOCKETtype for handling sockets and thenfdsparameter ofselect()is ignored but kept for compatibity with BSD standard.Expecting to handle sockets by not assuming to be an
inttype, this could cause a complain from MSVC when compiling for 64bit for Windows because incompatible types, so it would be better to just ignore this and just leavenfdsto zero for the future.See also here:
https://learn.microsoft.com/en-us/windows/win32/api/winsock2/nf-winsock2-select