Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/tags #2300

Merged
merged 12 commits into from
Jan 28, 2021
Merged

Hotfix/tags #2300

merged 12 commits into from
Jan 28, 2021

Conversation

andre-merzky
Copy link
Member

forward compatibility for tags - see radical-cybertools/radical.entk/issues/429

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #2300 (4e83814) into devel (3a53618) will increase coverage by 0.02%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #2300      +/-   ##
==========================================
+ Coverage   34.81%   34.84%   +0.02%     
==========================================
  Files          82       82              
  Lines        8908     8912       +4     
==========================================
+ Hits         3101     3105       +4     
  Misses       5807     5807              
Impacted Files Coverage Δ
src/radical/pilot/agent/scheduler/continuous.py 72.37% <75.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a53618...6e968c0. Read the comment docs.

Copy link
Contributor

@iparask iparask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving of the change since I know it works! I'll try to create a test case for tags.

@andre-merzky
Copy link
Member Author

I'll try to create a test case for tags.

Thank you!

@iparask
Copy link
Contributor

iparask commented Jan 19, 2021

@andre-merzky I added the test case. I'll do more while writing more tests.

@andre-merzky
Copy link
Member Author

@andre-merzky I added the test case. I'll do more while writing more tests.

Is this good to merge, or should we wait for those other tests?

@iparask
Copy link
Contributor

iparask commented Jan 25, 2021

I see that one of the tests fails. After that is fixed we can merge and I will add tests during my testing day. :)

@andre-merzky
Copy link
Member Author

I see that one of the tests fails. After that is fixed we can merge and I will add tests during my testing day. :)

This should be fixed now. I don't see how the test can have worked before though: the unit fed into the scheduler is unit.000000, but the test checks if the tag history has been filled for unit.000001?

@andre-merzky andre-merzky merged commit ad5a03e into devel Jan 28, 2021
@andre-merzky andre-merzky deleted the hotfix/tags branch January 28, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants