-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/tags #2300
Hotfix/tags #2300
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #2300 +/- ##
==========================================
+ Coverage 34.81% 34.84% +0.02%
==========================================
Files 82 82
Lines 8908 8912 +4
==========================================
+ Hits 3101 3105 +4
Misses 5807 5807
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving of the change since I know it works! I'll try to create a test case for tags.
Thank you! |
@andre-merzky I added the test case. I'll do more while writing more tests. |
Is this good to merge, or should we wait for those other tests? |
I see that one of the tests fails. After that is fixed we can merge and I will add tests during my testing day. :) |
This should be fixed now. I don't see how the test can have worked before though: the unit fed into the scheduler is |
forward compatibility for tags - see radical-cybertools/radical.entk/issues/429