-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated CI #381
updated CI #381
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #381 +/- ##
==========================================
- Coverage 62.47% 62.26% -0.21%
==========================================
Files 62 61 -1
Lines 6819 6777 -42
==========================================
- Hits 4260 4220 -40
+ Misses 2559 2557 -2 ☔ View full report in Codecov by Sentry. |
What is the plan for this PR? :-) |
@andre-merzky should we re-review this PR (just that #404 stuck with codecov worries me), I'm ok if you'll take over this PR |
Yep, I am game to get this one done. The Codecov timeouts are really annoying, they pop up more and more frequently nowadays. I added a timeout to #404 now, but well, that causes the tests to fail which is not much better ... Let's discuss codecov on the next call... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - thanks!
No description provided.