Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated CI #381

Merged
merged 36 commits into from
Apr 30, 2024
Merged

updated CI #381

merged 36 commits into from
Apr 30, 2024

Conversation

mtitov
Copy link
Collaborator

@mtitov mtitov commented Apr 18, 2023

No description provided.

@mtitov mtitov marked this pull request as draft April 18, 2023 03:45
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.26%. Comparing base (9095c33) to head (14e0ef3).
Report is 174 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #381      +/-   ##
==========================================
- Coverage   62.47%   62.26%   -0.21%     
==========================================
  Files          62       61       -1     
  Lines        6819     6777      -42     
==========================================
- Hits         4260     4220      -40     
+ Misses       2559     2557       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andre-merzky
Copy link
Member

What is the plan for this PR? :-)

@mtitov
Copy link
Collaborator Author

mtitov commented Apr 30, 2024

@andre-merzky should we re-review this PR (just that #404 stuck with codecov worries me), I'm ok if you'll take over this PR

@andre-merzky
Copy link
Member

@andre-merzky should we re-review this PR (just that #404 stuck with codecov worries me), I'm ok if you'll take over this PR

Yep, I am game to get this one done. The Codecov timeouts are really annoying, they pop up more and more frequently nowadays. I added a timeout to #404 now, but well, that causes the tests to fail which is not much better ... Let's discuss codecov on the next call...

@andre-merzky andre-merzky marked this pull request as ready for review April 30, 2024 06:37
Copy link
Member

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - thanks!

@mtitov mtitov merged commit 755165a into devel Apr 30, 2024
8 checks passed
@mtitov mtitov deleted the fix/ci branch April 30, 2024 16:01
@mtitov mtitov added the internal label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants