fix: only connect UDP if requested (#11)

We do not need to connect to UDP if we aren't using the UDP connection.
radiorabe · May 8, 2020 · c70a830 · c70a830
1 parent 6fd2485
commit c70a830
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/box/box.go b/box/box.go
@@ -111,7 +111,6 @@ func waitAndRead(pathfinder net.Conn, target *net.UDPConn) {
 	pinIsLow := regexp.MustCompile(`PinState=[lL]`)
 
 	defer pathfinder.Close()
-	defer target.Close()
 
 	for {
 		log.Debug("Reading from Pathfinder.")
@@ -147,9 +146,13 @@ func Execute(sendUDP bool, targetAddr string, pathfinderAddr string, pathfinderA
 		Socket = connectSocket(socketPath)
 		SocketPattern = socketPattern
 	}
-	log.Info("Connecting...")
-	target := connectUDP(targetAddr)
-	log.Infof("Connected to target %s", targetAddr)
+	var target *net.UDPConn
+	if sendUDP {
+		log.Info("Connecting UDP...")
+		target = connectUDP(targetAddr)
+		log.Infof("Connected to target %s", targetAddr)
+		defer target.Close()
+	}
 	pathfinder := connectTCP(pathfinderAddr)
 	log.Infof("Connected to pathfinder %s", pathfinderAddr)