Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate: build-tool use vite replace vue-cli #72

Merged
merged 33 commits into from
Nov 29, 2023

Conversation

little-buddy
Copy link
Collaborator

@little-buddy little-buddy commented Oct 29, 2023

Step Status
serve-web
build-web todo
electron-build todo
build-ci todo

@Linkontoask Linkontoask requested review from Linkontoask and hq001 and removed request for hq001 and Linkontoask October 30, 2023 02:23
@Linkontoask
Copy link
Contributor

Any progress?

@little-buddy
Copy link
Collaborator Author

little-buddy commented Nov 7, 2023

It’s been a while, but I’m still working 💪🏻

Step Status
serve-web
build-web
electron-build todo
build-ci todo

@little-buddy
Copy link
Collaborator Author

little-buddy commented Nov 12, 2023

Step Status
serve-web
build-web
electron-build
build-ci todo

@little-buddy little-buddy force-pushed the next branch 2 times, most recently from 706ed13 to e800e2d Compare November 20, 2023 02:40
@little-buddy
Copy link
Collaborator Author

Step Status
serve-web
build-web
electron-build
build-ci

Now!!!
ci can build on macos, but it is not adapted for other platforms.
Except remove loading box, others workd fine.
🎸🎸🎸

@Linkontoask
Copy link
Contributor

Step Status
serve-web ✅
build-web ✅
electron-build ✅
build-ci ✅
Now!!! ci can build on macos, but it is not adapted for other platforms. Except remove loading box, others workd fine. 🎸🎸🎸

Later I will try to see if the windows system is normal

Copy link
Contributor

@Linkontoask Linkontoask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

export-env.sh Outdated
@@ -0,0 +1,5 @@
export ELECTRON_MIRROR=https://npmmirror.com/mirrors/electron/
export ELECTRON_BUILDE_RBINARIES_MIRROR=https://npmmirror.com/mirrors/electron-builder-binaries/
echo "\033[32m ===================================================== \033[0m"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will this script be invoked

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only run yarn mirrori in China for electron

@Linkontoask Linkontoask reopened this Nov 28, 2023
package.json Outdated
"build:electron:linux": "node script/build.js --linux",
"build:electron:macos": "node script/build.js --mac",
"build:api": "lerna exec --scope @radishes/api -- yarn run build",
"pkg": "rm -rf dist-electron && yarn build:electron && npx electron-builder --config .electron-builder.config.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows does not have the rm command, so you need to use rimraf to be compatible with different systems

"build:electron:linux": "node script/build.js --linux",
"build:electron:macos": "node script/build.js --mac",
"build:api": "lerna exec --scope @radishes/api -- yarn run build",
"pkg": "npx rimraf dist-electron && yarn build:electron && npx electron-builder --config .electron-builder.config.js",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix it @Linkontoask

@Linkontoask Linkontoask merged commit f6b2134 into radishes-music:next Nov 29, 2023
@Linkontoask
Copy link
Contributor

🎉🎉🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants