Remove skipped resources workaround #109
Conversation
Signed-off-by: sk593 <[email protected]>
| "AWS::SageMaker::Cluster": {}, | ||
| } | ||
| // These will be reverted when the issue is resolved, but the map will be kept for future use if needed. | ||
| var skippedResources = map[string]struct{}{} |
There was a problem hiding this comment.
The resources were removed but I kept the map so we don't need to reimplement the logic if we run into the same issue in the future. I'm open to removing it but I kept it as a "just in case" since it's an error that AWS would need to fix, not us.
|
aws/aws-sdk-go-v2#2913 is still open. Did they fix it without closing the issue? |
The issue was from the CFN API, not the AWS SDK so they wouldn't be able to fix it. I did submit another issue here in case that raised awareness: aws-cloudformation/cloudformation-coverage-roadmap#2213 It seems like the CFN API was updated in between and removed the missing schema errors but I'm not sure whether that info was passed down to the other repos. |
Signed-off-by: sk593 <[email protected]>
sk593
dismissed stale reviews from willdavsmith and brooke-hamilton
via
965fd59
This reverts the change implemented in #96 since the schema has been updated.