updating doc to use DE from existing installation #7964

nithyatsu · 2024-09-25T19:38:34Z

Description

deployment-engine is currently a private repo. Updating contributor docs to use DE from existing installation.

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

rynowak · 2024-09-25T19:41:06Z

.vscode/launch.json

-                "KUBERNETESBICEPEXTENSIBILITYURL": "http://localhost:5017/api",
-                "RADIUSBACKENDURI": "http://localhost:9000",
-            },
-        },


Can we leave this here? It's still useful.

That gives users the choice of either:

Using the DE from a cluster

Using the DE from local source code

codecov · 2024-09-25T19:49:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.83%. Comparing base (283e44f) to head (5d466a5).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7964   +/-   ##
=======================================
  Coverage   59.83%   59.83%           
=======================================
  Files         590      590           
  Lines       39520    39520           
=======================================
  Hits        23646    23646           
  Misses      14119    14119           
  Partials     1755     1755

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2024-09-30T17:16:27Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`053fc7a`
Unique ID	func1aa52fd8f9
Image tag	pr-func1aa52fd8f9

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1aa52fd8f9
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1aa52fd8f9
controller test image location: ghcr.io/radius-project/dev/controller:pr-func1aa52fd8f9
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1aa52fd8f9
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2024-10-03T19:05:10Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`0cb2e2f`
Unique ID	func7055ff007b
Image tag	pr-func7055ff007b

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func7055ff007b
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func7055ff007b
controller test image location: ghcr.io/radius-project/dev/controller:pr-func7055ff007b
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func7055ff007b
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2024-10-03T20:15:22Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`9521bd7`
Unique ID	func7f480caeed
Image tag	pr-func7f480caeed

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func7f480caeed
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func7f480caeed
controller test image location: ghcr.io/radius-project/dev/controller:pr-func7f480caeed
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func7f480caeed
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

kachawla

Thanks for updating this @nithyatsu. Were you able validate that this setup works?

...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md

radius-functional-tests · 2025-01-14T22:06:48Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`5ba9434`
Unique ID	funcfdcc465fe5
Image tag	pr-funcfdcc465fe5

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcfdcc465fe5
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcfdcc465fe5
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcfdcc465fe5
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcfdcc465fe5
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcfdcc465fe5
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

ytimocin · 2025-01-18T05:17:06Z

...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md

-6. (Optional) Configure any cloud provider credentials you want to use for developing Radius.
+1. Create a Kubernetes cluster, or set your current context to a cluster you want to use. The debug configuration will use your current cluster for storing data. 
+2. If you have access to `radius-project/deployment-engine` repo, 
+   1. Clone the `radius-project/radius` and `radius-project/deployment-engine` repo next to each other.


Suggested change

1. Clone the `radius-project/radius` and `radius-project/deployment-engine` repo next to each other.

1. Clone the `radius-project/radius` and `radius-project/deployment-engine` repos next to each other.

ytimocin · 2025-01-18T05:18:37Z

...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md

+        "Launch Applications RP",
+        "Launch Dynamic RP",
+        "Launch Controller",
+        // "Launch Deployment Engine"


This is only if we are running Deployment Engine as a container, right? Should we specify that or delete this line all together?

kachawla · 2025-01-27T02:39:08Z

...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md

-5. Install C# VS Code extension - <https://marketplace.visualstudio.com/items?itemName=ms-dotnettools.csharp>.
-6. (Optional) Configure any cloud provider credentials you want to use for developing Radius.
+1. Create a Kubernetes cluster, or set your current context to a cluster you want to use. The debug configuration will use your current cluster for storing data. 
+2. If you have access to `radius-project/deployment-engine` repo, 


Can write down this and Setup Step 4: Run Deployment Engine as docker container as either/or? Even if someone has access, they don't need to clone it and can directly run DE in a container?

kachawla · 2025-01-27T02:40:51Z

...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md

+        "Launch Applications RP",
+        "Launch Dynamic RP",
+        "Launch Controller",
+        // "Launch Deployment Engine"


This can be a bit confusing, let's separate out the two paths with clearer instructions. You either clone the repo or spin it up in container and call out any updates required to launch config in each scenario.

kachawla · 2025-01-27T02:41:44Z

...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md

 - Press Debug

-Wait for all 3 of these to start.
+Wait for all the services to start.


Thanks for updating this.

kachawla · 2025-01-27T02:42:28Z

...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md

+
+> 💡 This step is required only if you are an external contributor and do not have access to `radius-project/deployment-engine` repo.
+> 
+`docker run  -e RADIUSBACKENDURL=http://host.docker.internal:9000/apis/api.ucp.dev/v1alpha3 -p 5017:8080 ghcr.io/radius-project/deployment-engine:latest`


Are there any prerequisites to running this command that we should mention here?

nithyatsu requested review from a team as code owners September 25, 2024 19:38

rynowak reviewed Sep 25, 2024

View reviewed changes

nithyatsu temporarily deployed to functional-tests September 30, 2024 17:15 — with GitHub Actions Inactive

nithyatsu force-pushed the update_doc branch from 053fc7a to 0cb2e2f Compare October 3, 2024 16:22

nithyatsu temporarily deployed to functional-tests October 3, 2024 19:04 — with GitHub Actions Inactive

nithyatsu requested a review from rynowak October 3, 2024 20:13

nithyatsu temporarily deployed to functional-tests October 3, 2024 20:14 — with GitHub Actions Inactive

kachawla reviewed Oct 4, 2024

View reviewed changes

...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md Outdated Show resolved Hide resolved

...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md Outdated Show resolved Hide resolved

nithyatsu had a problem deploying to functional-tests November 13, 2024 20:53 — with GitHub Actions Failure

update docs for external contributors with no access to de repo

03d5bb7

nithyatsu force-pushed the update_doc branch from 489772a to 03d5bb7 Compare January 13, 2025 17:03

nithyatsu temporarily deployed to publish-bicep January 13, 2025 17:03 — with GitHub Actions Inactive

nit

7c5d632

nithyatsu temporarily deployed to publish-bicep January 13, 2025 17:12 — with GitHub Actions Inactive

wip

5ba9434

nithyatsu temporarily deployed to publish-bicep January 13, 2025 17:19 — with GitHub Actions Inactive

nithyatsu temporarily deployed to functional-tests January 14, 2025 22:06 — with GitHub Actions Inactive

Merge branch 'main' into update_doc

a160268

nithyatsu temporarily deployed to publish-bicep January 14, 2025 22:06 — with GitHub Actions Inactive

Merge branch 'main' into update_doc

5d466a5

nithyatsu temporarily deployed to publish-bicep January 17, 2025 20:41 — with GitHub Actions Inactive

ytimocin reviewed Jan 18, 2025

View reviewed changes

kachawla reviewed Jan 27, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updating doc to use DE from existing installation #7964

updating doc to use DE from existing installation #7964

nithyatsu commented Sep 25, 2024

rynowak Sep 25, 2024

codecov bot commented Sep 25, 2024 •

edited

Loading

radius-functional-tests bot commented Sep 30, 2024 •

edited

Loading

radius-functional-tests bot commented Oct 3, 2024 •

edited

Loading

radius-functional-tests bot commented Oct 3, 2024 •

edited

Loading

kachawla left a comment

radius-functional-tests bot commented Jan 14, 2025 •

edited

Loading

ytimocin Jan 18, 2025

ytimocin Jan 18, 2025

kachawla Jan 27, 2025

kachawla Jan 27, 2025

kachawla Jan 27, 2025

kachawla Jan 27, 2025

	1. Clone the `radius-project/radius` and `radius-project/deployment-engine` repo next to each other.
	1. Clone the `radius-project/radius` and `radius-project/deployment-engine` repos next to each other.

updating doc to use DE from existing installation #7964

Are you sure you want to change the base?

updating doc to use DE from existing installation #7964

Conversation

nithyatsu commented Sep 25, 2024

Description

Type of change

rynowak Sep 25, 2024

Choose a reason for hiding this comment

codecov bot commented Sep 25, 2024 • edited Loading

Codecov Report

radius-functional-tests bot commented Sep 30, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Oct 3, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Oct 3, 2024 • edited Loading

Radius functional test overview

Test Status

kachawla left a comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Jan 14, 2025 • edited Loading

Radius functional test overview

Test Status

ytimocin Jan 18, 2025

Choose a reason for hiding this comment

ytimocin Jan 18, 2025

Choose a reason for hiding this comment

kachawla Jan 27, 2025

Choose a reason for hiding this comment

kachawla Jan 27, 2025

Choose a reason for hiding this comment

kachawla Jan 27, 2025

Choose a reason for hiding this comment

kachawla Jan 27, 2025

Choose a reason for hiding this comment

codecov bot commented Sep 25, 2024 •

edited

Loading

radius-functional-tests bot commented Sep 30, 2024 •

edited

Loading

radius-functional-tests bot commented Oct 3, 2024 •

edited

Loading

radius-functional-tests bot commented Oct 3, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 14, 2025 •

edited

Loading