Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove validation of resource types against the static list in recipes codebase #8391

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

nithyatsu
Copy link
Contributor

@nithyatsu nithyatsu commented Jan 31, 2025

Description

Since we now have APIs that lets us query the valid resourcetypes and the resource types can include UDTs, we refactored the code to remove the validation of resource types against the static list of redaius resource types.

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).

Fixes: https://dev.azure.com/azure-octo/Incubations/_workitems/edit/13653/

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

@nithyatsu nithyatsu changed the title remove validation of resource types against the static list remove validation of resource types against the static list in recipes codebase Feb 10, 2025
@nithyatsu nithyatsu marked this pull request as ready for review February 10, 2025 23:55
@nithyatsu nithyatsu requested review from a team as code owners February 10, 2025 23:55
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 61.11111% with 28 lines in your changes missing coverage. Please review.

Project coverage is 59.94%. Comparing base (ea992df) to head (43e33cc).

Files with missing lines Patch % Lines
...orerp/backend/controller/createorupdateresource.go 59.52% 12 Missing and 5 partials ⚠️
...g/corerp/backend/deployment/deploymentprocessor.go 57.69% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8391      +/-   ##
==========================================
- Coverage   59.94%   59.94%   -0.01%     
==========================================
  Files         596      595       -1     
  Lines       40432    40435       +3     
==========================================
+ Hits        24238    24239       +1     
+ Misses      14367    14364       -3     
- Partials     1827     1832       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant