-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GH_RAD_CI_BOT_PAT and replace it with GH APP Token #8392
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Vishwanath Hiremath <[email protected]>
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8392 +/- ##
==========================================
- Coverage 59.95% 59.94% -0.02%
==========================================
Files 596 596
Lines 40432 40432
==========================================
- Hits 24241 24235 -6
- Misses 14365 14369 +4
- Partials 1826 1828 +2 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
⌛ Building Radius and pushing container images for functional tests... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to test the changes before merging them in?
@@ -5,6 +5,9 @@ on: | |||
types: | |||
[opened, edited, deleted, closed, reopened, labeled, unlabeled, assigned] | |||
|
|||
env: | |||
FUNCTIONAL_TEST_APP_ID: 425843 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also be an org-wide or repo-wide secret?
Description
Remove GH_RAD_CI_BOT_PAT and replace it with GH APP Token
Type of change
Fixes: #issue_number
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: