Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GH_RAD_CI_BOT_PAT and replace it with GH APP Token #8392

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vishwahiremat
Copy link
Contributor

Description

Remove GH_RAD_CI_BOT_PAT and replace it with GH APP Token

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).
  • This pull request adds or changes features of Radius and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

@vishwahiremat vishwahiremat requested review from a team as code owners January 31, 2025 22:14
@vishwahiremat vishwahiremat marked this pull request as draft January 31, 2025 22:14
@radius-functional-tests

This comment has been minimized.

Copy link

Unit Tests

3 612 tests  ±0   3 610 ✅ ±0   6m 6s ⏱️ -2s
  295 suites ±0       2 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 2e36a9c. ± Comparison against base commit 87ce431.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.94%. Comparing base (87ce431) to head (2e36a9c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8392      +/-   ##
==========================================
- Coverage   59.95%   59.94%   -0.02%     
==========================================
  Files         596      596              
  Lines       40432    40432              
==========================================
- Hits        24241    24235       -6     
- Misses      14365    14369       +4     
- Partials     1826     1828       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radius-functional-tests

This comment has been minimized.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Feb 3, 2025

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
❌ Failed to install Radius for ucp-cloud functional test. Please check the logs for more details
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

Copy link
Contributor

@ytimocin ytimocin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to test the changes before merging them in?

@@ -5,6 +5,9 @@ on:
types:
[opened, edited, deleted, closed, reopened, labeled, unlabeled, assigned]

env:
FUNCTIONAL_TEST_APP_ID: 425843
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be an org-wide or repo-wide secret?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants