Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added supporting non ascii symbols #12 #23

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Added supporting non ascii symbols #12 #23

merged 1 commit into from
Oct 14, 2023

Conversation

WindowGenerator
Copy link
Contributor

@WindowGenerator WindowGenerator commented Oct 12, 2023 •
edited
Loading

Issue #12

  • Formatted all code with cargo fmt
  • Fixed some tests related to non-ascii chars
  • Added non-ascii supporing

image

@WindowGenerator WindowGenerator changed the title Added supporting non ascii symbols Added supporting non ascii symbols #12 Oct 12, 2023
radlinskii
radlinskii reviewed Oct 14, 2023
View reviewed changes
Copy link
Owner

@radlinskii radlinskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! looks clean! 👏

I'm putting hacktoberfest-accepted label, but if you want to merge it please resolve the conflicts first.

src/expected_input.rs Outdated Show resolved Hide resolved
@WindowGenerator WindowGenerator force-pushed the add-supporting-non-ascii-chars branch from 87b980f to a11c8f8 Compare October 14, 2023 15:09
radlinskii
radlinskii approved these changes Oct 14, 2023
View reviewed changes
Copy link
Owner

@radlinskii radlinskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@radlinskii radlinskii merged commit f12c6f4 into radlinskii:main Oct 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radlinskii radlinskii radlinskii approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WindowGenerator @radlinskii