Wpm calculation #27
Closed
Wpm calculation #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I changed how get_string() works so the checks are failing |
|
Should I create a new function for just this usecase? |
radlinskii
reviewed
Oct 18, 2023
src/test_results.rs
Outdated
| @@ -113,6 +113,44 @@ impl TestResults { | |||
| } | |||
| } | |||
|
|
|||
| pub fn get_total_words_correct(spaces: &Vec<usize>, typed_string: &String, expected_input: &String, typed_character_count: usize) -> u32{ | |||
There was a problem hiding this comment.
would be nice to have a unit test for this function
There was a problem hiding this comment.
Ok I'll create a couple of tests
src/expected_input.rs
Outdated
| @@ -120,16 +119,25 @@ pub trait ExpectedInputInterface { | |||
| } | |||
|
|
|||
| impl ExpectedInputInterface for ExpectedInput { | |||
| /// Cuts string saved in ExpectedInput at specified length instance and returns it | |||
| /// Cuts string saved in ExpectedInput at a whitespace character present after the specified length and returns it | |||
There was a problem hiding this comment.
hmm I'm not sure about this change, the logic to cut the input in some exact space is to make sure that the text displayed in the terminal takes exactly one line
There was a problem hiding this comment.
Isn't the get_string() only being used to get the expected input for comparison with the actual input or am I mistaken? I changed it thinking that was it's only function
MercMayhem
force-pushed
the
wpm-calculation
branch
from
ccbd3bc to
3e1a805
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5 by modifying wpm calculation to be done using words correct instead of by characters correct.