Bug fix: Fix configuration bug in radvd upstream - issue 220 #222
+21
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audreylace
changed the title
robbat2
requested changes
Dec 9, 2023
Comment on lines
+576
to
+593
|
|
||
| /* | ||
| * check that 'other' cannot write the file | ||
| * for non-root, also that self/own group can't either | ||
| */ | ||
| int do_reload = 1; | ||
| if (check_conffile_perm(username, conf_path) != 0) { | ||
| if (get_debuglevel() == 0) { | ||
| flog(LOG_ERR, "permissions on conf_file invalid, ignoring reload request"); | ||
| do_reload = 0; | ||
| } else { | ||
| flog(LOG_WARNING, "Insecure file permissions, but continuing reload anyway"); | ||
| } | ||
| } | ||
|
|
||
| if (do_reload) { | ||
| ifaces = reload_config(sock, ifaces, conf_path); | ||
| } |
There was a problem hiding this comment.
this just almost-duplicates the existing code.
Please refactor to introduce a new function that gets used in both places, and either exits or skips reloading in the caller.
|
@audreylace: Have you seen @robbat2 comment? |
|
@audreylace are you going to refactor, I would consider this a soft blocker for the 2.20 release |
|
@robbat2: It is only this which blocks a 2.20? What must be changed in this @audreylace PR to be merged? |
|
@audreylace: Any progress on it? |
|
@audreylace: Can you look @robbat2 comment from 2023-12-09? |
|
@audreylace: Why have you closed your PR? :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue 220. We will now check the permissions of the configuration file before reloading. If the checks fail, then the reload request is ignored.