feat: Adds nice!view functionality to repository #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the required changes to allow the use of a nice!view. Adding the nice_view_adapter and nice_view shields to the build.yaml file lead to errors during the compilation of the files. In order to address the errors, The Kconfig.defconfig file was edited to remove the ZMK_DISPLAY and LVGL sections and in the temper.dtsi file, the zephyr,display = &oled line had to be deleted. I also removed the deep sleep config and replaced it with the display config in the temper.config file
|
Accidentally closed, when I was trying to move my own personal changes to a different branch |
|
Thanks! I will merge this once I can verify that it works for me too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the required changes to allow the use of a nice!view. Adding the nice_view_adapter and nice_view shields to the build.yaml file lead to errors during the compilation of the files. In order to address the errors, The
Kconfig.defconfigfile was edited to remove theZMK_DISPLAYandLVGLsections and in thetemper.dtsifile, thezephyr,display = &oledline had to be deleted. I also removed the deep sleep config and replaced it with the display config in thetemper.configfile.This was tested on my own build of the Temper Keyboard before submitting the pull request.
