lists: Fix unnecessary separation line in permissions list

Firefox 121 enables the has() selector, now we ca use it to fix this issue. Fixes #654
rafaelmardojai · Nov 22, 2023 · 4a7dccf · 4a7dccf
1 parent 1208b24
commit 4a7dccf
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/theme/parts/lists.css b/theme/parts/lists.css
@@ -22,15 +22,26 @@ richlistbox#items {
 }
 
 /* List item */
-.permission-popup-permission-list-anchor,
+.permission-popup-permission-item,
 richlistbox#items richlistitem {
 	padding: 6px !important;
 	margin: 0 !important;
 }
-.permission-popup-permission-list-anchor:not(:last-child),
+.permission-popup-permission-list-anchor {
+	padding: 0 !important;
+}
+.permission-popup-permission-list-anchor:not(:has(.permission-popup-permission-item)) {
+	visibility: collapse;
+}
 richlistbox#items richlistitem:not(:last-child) {
 	border-bottom: 1px solid var(--gnome-card-shade-color);
 }
+.permission-popup-permission-list-anchor:not(#permission-popup-permission-list-default-anchor):has(.permission-popup-permission-item) {
+	border-top: 1px solid var(--gnome-card-shade-color);
+}
+#permission-popup-permission-list-default-anchor:empty + .permission-popup-permission-list-anchor {
+	border: 0 !important;
+}
 
 /* Fix list buttons on selected state */
 @media (prefers-color-scheme: light) {

diff --git a/theme/parts/popups-contents.css b/theme/parts/popups-contents.css
@@ -190,7 +190,6 @@
 
 #permission-popup-permission-list-default-anchor:empty {
 	padding: 0 !important;
-	border: 0 !important;
 }
 .permission-popup-permission-list-anchor[anchorfor="3rdPartyStorage"] {
 	padding: 0 !important;