Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad change #14

Open
wants to merge 1 commit into
base: codeowners
Choose a base branch
from
Open

Bad change #14

wants to merge 1 commit into from

Conversation

raffenet
Copy link
Owner

@raffenet raffenet commented Jun 3, 2020

Pull Request Description

Expected Impact

Author Checklist

  • Reference appropriate issues (with "Fixes" or "See" as appropriate)
  • Remove xfail from the test suite when fixing a test
  • Commits are self-contained and do not do two things at once
  • Commit message is of the form: module: short description and follows good practice
  • Passes whitespace checkers
  • Passes warning tests
  • Passes all tests
  • Add comments such that someone without knowledge of the code could understand
  • You or your company has a signed contributor's agreement on file with Argonne
  • For non-Argonne authors, request an explicit comment from your companies PR approval manager

@raffenet raffenet force-pushed the codeowners branch 2 times, most recently from d49aa23 to d55c084 Compare June 3, 2020 19:03
@raffenet raffenet requested a review from pmrsbot as a code owner June 3, 2020 19:03
@raffenet raffenet force-pushed the codeowners branch 2 times, most recently from 3780c0a to ce07bf5 Compare November 23, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmrsbot pmrsbot Awaiting requested review from pmrsbot

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@raffenet