Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte #686

Merged
merged 36 commits into from
Dec 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
ec2a7ef
Create typed Message for webviews
Heliozoa Aug 22, 2023
939c220
Mimic svelte hello world setup
Heliozoa Aug 22, 2023
ed840bb
Init webview-ui
Heliozoa Aug 22, 2023
d012d6e
Add scripts
Heliozoa Aug 22, 2023
01ed380
temp
Heliozoa Aug 28, 2023
77c6b84
Progress on the new svelte frontend
Heliozoa Sep 7, 2023
d4abf09
Work on svelte
Heliozoa Oct 19, 2023
af9d2a5
Merge remote-tracking branch 'origin/master' into svelte
Heliozoa Oct 19, 2023
0ac7e11
Fixed error and switch from custom eslint rule to existing
Heliozoa Oct 19, 2023
d96ba10
Improved styling and fixed issues
Heliozoa Oct 24, 2023
ee8b3f7
Progress on the new svelte frontend
Heliozoa Nov 28, 2023
f3bfd27
Ignore shared in prettier
Heliozoa Nov 28, 2023
721728f
Test cancellation and cleanup
Heliozoa Dec 5, 2023
daf001c
Fixes to tests etc
Heliozoa Dec 5, 2023
3c6d0df
Improve tests
Heliozoa Dec 5, 2023
6bb4733
Fix CI, clean up UI
Heliozoa Dec 7, 2023
5d21c9e
Remove obsolete test setup
Heliozoa Dec 7, 2023
b4909f4
Fix prettier ignores
Heliozoa Dec 7, 2023
4830355
Stop using deprecated action
Heliozoa Dec 7, 2023
e4d0b03
Improve UI, add Card and ProgressBar
Heliozoa Dec 12, 2023
53b8c46
Remove old templates
Heliozoa Dec 12, 2023
74243ef
Try to fix CI
Heliozoa Dec 12, 2023
7f67104
Add missing file
Heliozoa Dec 12, 2023
85fe028
Remove old CI step
Heliozoa Dec 12, 2023
68284bc
Fix eslint command
Heliozoa Dec 12, 2023
c3ba399
Build webview before playwright tests
Heliozoa Dec 12, 2023
25d9bdf
Try to fix CI line endings
Heliozoa Dec 12, 2023
0e853b8
Install rollup in CI
Heliozoa Dec 12, 2023
8a33347
Try to fix CI
Heliozoa Dec 12, 2023
c61f7cd
Try to fix CI by adding delays to playwright tests
Heliozoa Dec 12, 2023
d1b7d3b
Increase timeouts
Heliozoa Dec 12, 2023
abcb734
Updated test-electron
Heliozoa Dec 12, 2023
93f3500
Increase timeout even more
Heliozoa Dec 12, 2023
1f76ced
Increase timeout even more
Heliozoa Dec 12, 2023
5a5dff4
Click checkbox instead of checking in CI
Heliozoa Dec 12, 2023
0a70fe8
Try to remove the timeout
Heliozoa Dec 13, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
151 changes: 151 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,151 @@
module.exports = {
root: true,
env: {
es6: true,
node: true,
},
extends: [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
"plugin:import/errors",
"plugin:import/warnings",
"plugin:import/typescript",
"plugin:prettier/recommended",
],
globals: {
Atomics: "readonly",
SharedArrayBuffer: "readonly",
},
parser: "@typescript-eslint/parser",
parserOptions: {
ecmaVersion: 6,
sourceType: "module",
},
plugins: ["@typescript-eslint", "import", "prettier", "sort-class-members"],
settings: {
"import/core-modules": ["vscode"],
},
rules: {
"no-unused-vars": "off",
// unused vars are allowed if they start with an underscore
"@typescript-eslint/no-unused-vars": [
"warn",
{
varsIgnorePattern: "^_",
argsIgnorePattern: "^_",
caughtErrorsIgnorePattern: "^_",
destructuredArrayIgnorePattern: "^_",
},
],

"@typescript-eslint/ban-ts-comment": ["error", { "ts-ignore": "allow-with-description" }],
"import/no-named-as-default": "off",
curly: "error",
"sort-imports": [
"error",
{
ignoreCase: true,
ignoreDeclarationSort: true,
},
],
"import/order": [
"error",
{
alphabetize: {
order: "asc",
},
groups: [["builtin", "external"], "parent", "sibling", "index"],
"newlines-between": "always",
},
],
"@typescript-eslint/no-var-requires": "off",
// == disabled default configs from svelte template ==
/*
"@typescript-eslint/no-use-before-define": [
"error",
{
classes: false,
functions: false,
},
],
quotes: "off",
"@typescript-eslint/quotes": ["error", "double", { avoidEscape: true }],
"@typescript-eslint/explicit-function-return-type": "off",
"@typescript-eslint/explicit-module-boundary-types": "off",
"@typescript-eslint/no-empty-function": "off",
"@typescript-eslint/no-var-requires": "off",
"@typescript-eslint/semi": ["error"],
"@typescript-eslint/lines-between-class-members": [
"error",
"always",
{ exceptAfterSingleLine: true },
],
"@typescript-eslint/naming-convention": [
"error",
{
selector: "function",
format: ["camelCase"],
},
{
selector: "method",
modifiers: ["public"],
format: ["camelCase"],
},
{
selector: "method",
modifiers: ["private"],
format: ["camelCase"],
leadingUnderscore: "require",
},
{
selector: "property",
modifiers: ["private"],
format: ["camelCase"],
leadingUnderscore: "require",
},
{
selector: "typeLike",
format: ["PascalCase"],
},
],
"max-len": [
"warn",
{
code: 130,
comments: 100,
ignoreComments: false,
},
],
eqeqeq: ["error"],
"sort-class-members/sort-class-members": [
2,
{
order: [
"[static-properties]",
"[static-methods]",
"[properties]",
"[conventional-private-properties]",
"constructor",
"[methods]",
"[conventional-private-methods]",
"[everything-else]",
],
accessorPairPositioning: "getThenSet",
},
],
"no-throw-literal": "warn",
semi: "off",
*/
},
ignorePatterns: ["webview-ui/**"],
overrides: [
{
files: ["*.ts", "*.tsx"],
rules: {
"@typescript-eslint/explicit-function-return-type": ["error"],
"@typescript-eslint/explicit-module-boundary-types": ["error"],
"@typescript-eslint/no-var-requires": ["error"],
},
},
],
};
125 changes: 0 additions & 125 deletions .eslintrc.json

This file was deleted.

2 changes: 1 addition & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
@@ -1 +1 @@
text eol=lf
* text=auto eol=lf
1 change: 1 addition & 0 deletions .github/workflows/build-and-upload.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ jobs:
run: |
npm run ci:all
npm install -g @vscode/vsce
npm run webpack
vsce package ${{ env.PRERELEASE }}
# move packaged extension from project root to own release folder
mkdir extension && mv *.vsix extension
Expand Down
7 changes: 1 addition & 6 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,10 @@ jobs:
cd ..

- name: Unit tests
uses: GabrielBB/setup-xvfb@v1.0.1
uses: coactions/setup-xvfb@v1
with:
run: npm test

- name: Integration tests
uses: GabrielBB/[email protected]
with:
run: npm run test-integration-only integration

playwright_tests:
name: Playwright tests
env:
Expand Down
2 changes: 1 addition & 1 deletion .husky/lint-staged-config.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module.exports = {
"*.{html,js,json,jsx,ts,yml}": ["prettier --check"],
"*.{js,jsx,ts,tsx}": ["eslint --cache --max-warnings 0"],
"src/*.{js,jsx,ts,tsx}": ["eslint --cache --max-warnings 0"],
};
26 changes: 26 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# dependencies
/node_modules
/.pnp
.pnp.js

# testing
/coverage

# production
/build
/dist

# misc
.DS_Store
.env.local
.env.development.local
.env.test.local
.env.production.local

npm-debug.log*
yarn-debug.log*
yarn-error.log*

# shared
/src/shared
/webview-ui/src/shared
13 changes: 13 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"printWidth": 110,
"tabWidth": 2,
"useTabs": false,
"semi": true,
"singleQuote": false,
"quoteProps": "consistent",
"jsxSingleQuote": false,
"trailingComma": "es5",
"bracketSpacing": true,
"jsxBracketSameLine": true,
"arrowParens": "always"
}
3 changes: 2 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@
"html.validate.scripts": false,
"html.validate.styles": false,
"spellright.language": ["en"],
"spellright.documentTypes": ["markdown", "latex", "plaintext", "typescript"]
"spellright.documentTypes": ["markdown", "latex", "plaintext", "typescript"],
"eslint.validate": ["svelte"]
}
11 changes: 10 additions & 1 deletion .vscodeignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ out/**
src/**
submodules/**
test-resources/**
types/**

**/.dockerignore
**/.eslintcache
Expand Down Expand Up @@ -45,3 +44,13 @@ webpack.common.js
webpack.config.js
webpack.dev.js
webpack.prod.js

# Ignore all webview-ui files except the build directory
webview-ui/src/**
webview-ui/public/**
webview-ui/scripts/**
webview-ui/index.html
webview-ui/README.md
webview-ui/package.json
webview-ui/package-lock.json
webview-ui/node_modules/**
Loading
Loading