Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when changing TMC data path on Windows #708

Merged
merged 3 commits into from
Jan 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,18 @@ Update the `tmc-python-tester` submodule
git submodule init && git submodule update
```

Repeat the same for the testing backend:
Then prepare the backend:

```bash
cd backend && npm ci && npm run setup
```

As well as the webview:

```bash
cd webview && npm ci
```

You will need to rerun the setup when langs is updated, as this step will download the appropriate version of the CLI for the integration tests.

## Formatting
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion src/commands/changeTmcDataPath.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@ export async function changeTmcDataPath(actionContext: ActionContext): Promise<v
canSelectFolders: true,
canSelectMany: false,
openLabel: "Select folder",
defaultUri: vscode.Uri.parse(old),
defaultUri: vscode.Uri.file(old),
};

const newPath = (await vscode.window.showOpenDialog(options))?.[0];
if (newPath && old) {
const res = await dialog.progressNotification(
Expand Down
Loading