Allow calling scrollVertical with only the target
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the options are optional, but if an empty object is not passed
the `scrollVertical` method blows up with cannot reat offset of undefined.
Now we can scrollVertical('#id') instead of having scrollVertical('#id',{});
|
Seems sane to me |
|
Thanks a lot for the addon by the way 👍 This is just a micro-contribution for an issue I ran into (and thought that other people might have as well) |
|
Thanks, appreciate it! I don't have write on this repo so @jasonkriss will need to merge at his convenience. If you have any time to help us with #8 @corrspt that would be really awesome! |
jasonkriss
added a commit
that referenced
this pull request
Dec 18, 2015
Allow calling `scrollVertical` with only the target
|
@blimmer Just gave you write access btw. Seems silly that you wouldn't have it at this point. |
|
Thanks @jasonkriss ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that all options for the
scrollVerticalmethod of the service are optional but you need to pass an empty object as options.This PR makes the
optsdefault to an empty object, allowing us to callscrollVertical('target')instead ofscrollVertical('target', {})