feat: Make span when call DynamoDB API. #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythrnr
commented
Oct 18, 2023
Comment on lines
+72
to
+86
| ## Support `tokio-rs/tracing` | ||
|
|
||
| `raiden` supports making span for Tracing ( span name is `dynamodb::action` with table name and api name in field ). | ||
| To activate this feature, you need to specify `tracing` feature in your `Cargo.toml`. And your crate needs `tracing` . | ||
|
|
||
| ```toml | ||
| # Example | ||
| [dependencies] | ||
| raiden = { | ||
| tag = "0.0.76", | ||
| git = "https://github.com/raiden-rs/raiden-dynamo.git", | ||
| features = [ "tracing"] | ||
| } | ||
| tracing = "0.1" | ||
| ``` |
There was a problem hiding this comment.
Add description to activate tracing feature.
| @@ -1 +1 @@ | |||
| 1.66.1 | |||
| 1.67.0 | |||
There was a problem hiding this comment.
Update Rust toolchain
Comment on lines
+92
to
+97
| #[cfg_attr(feature = "tracing", tracing::instrument( | ||
| level = tracing::Level::DEBUG, | ||
| name = "dynamodb::action", | ||
| skip_all, | ||
| fields(api = "transact_write_items") | ||
| ))] |
There was a problem hiding this comment.
Make span at WriteTx::inner_run to wrap calling TransactWriteItems API.
This span does not support field for table name.
mythrnr
commented
Oct 18, 2023
Comment on lines
+95
to
+106
| let api_call_token = super::api_call_token!("batch_write_item"); | ||
| let (call_inner_run, inner_run_args) = if cfg!(feature = "tracing") { | ||
| ( | ||
| quote! { #builder_name::inner_run(&self.table_name, &self.client, input).await? }, | ||
| quote! { table_name: &str, }, | ||
| ) | ||
| } else { | ||
| ( | ||
| quote! { #builder_name::inner_run(&self.client, input).await? }, | ||
| quote! {}, | ||
| ) | ||
| }; |
There was a problem hiding this comment.
Create token stream to call DynamoDB API with span.
if feature tracing is not active, token stream will be created without making span.
Comment on lines
+90
to
+94
| let fut = fut.instrument(::tracing::debug_span!( | ||
| "dynamodb::action", | ||
| table = #table_name, | ||
| api = std::stringify!(#operation), | ||
| )); |
There was a problem hiding this comment.
This setting is same as next.
#[tracing::instrument(
level = tracing::Level::DEBUG,
name = "dynamodb::action",
skip_all,
fields(
table = "{table_name}",
api = "{operation}",
)
)]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
tracingto supporttokio-rs/tracing.cargo update.References
None.
Screenshots
None.
What can I check for bug fixes?
None.