Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix precision handling in time migration #1144

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

kiyot
Copy link
Contributor

@kiyot kiyot commented Dec 22, 2023

Resolved an issue where creating a time column with a precision of 7 would trigger the following error.

ArgumentError: No time type has precision of 7. The allowed range of precision is from 0 to 6 (ArgumentError)

kiyot and others added 3 commits December 22, 2023 16:14
Resolved an issue where creating a time column with a precision of 7 would trigger the following error.

> ArgumentError: No time type has precision of 7. The allowed range of precision is from 0 to 6 (ArgumentError)
@aidanharan
Copy link
Contributor

@kiyot Thanks for the PR. I made a small change so that I let the database handle the default precision by sending time to it instead of time(7).

@aidanharan aidanharan merged commit 1bf0e4c into rails-sqlserver:main Jan 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants