Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bun.write(Bun.stdout, '') for output in Bun executor #136

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Use Bun.write(Bun.stdout, '') for output in Bun executor #136

merged 1 commit into from
Oct 18, 2023

Conversation

tomocrafter
Copy link
Contributor

I encountered this issue in bun oven-sh/bun#6573 and I tried using Bun.write instead of process.stdout.write then I realized that above issue does not occurs. So I replaced with Bun.write to avoid this issue and potential performance optimize since Bun.write uses faster system call than normal one.

@byroot byroot merged commit bf06330 into rails:master Oct 18, 2023
15 checks passed
@tomocrafter tomocrafter deleted the use-bun-write-for-bun branch October 18, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants