Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add :force option to cache! #425

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bobdutch
Copy link

Before change 65dfb33 you could pass the :force option to cache! This worked because cache! used Rails.cache.fetch which takes the force option. That commit rewrote cache to use Rails.cache.read and Rails.cache.write which don't do anything with the force option. I use :force extensively in my jbuilder template to send a parameter that will clear and write the cache for the next request. I think this is a worthy feature to have even if it was an undocumented and unintentional feature of jbuilder pre-2.6.0
Closes #424

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@HarlemSquirrel
Copy link

@pixeltrix it would be awesome if you could spare a moment to review this. Thank you in advance!

@akodkod
Copy link

akodkod commented Jul 26, 2021

+1 for this

@ghost
Copy link

ghost commented Nov 11, 2023

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache! force option ignored?
5 participants