-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Rails to version 8.0.0 #41
base: main
Are you sure you want to change the base?
Conversation
@c-moyer do you know why this hasn't been merged already? |
I wonder how this works at all https://guides.rubyonrails.org/getting_started_with_devcontainer.html#installing-rails-new - as it's about Rails 8.0, which is not really supported w/o this MR is merged. 🤕 |
@axalix you can overwrite default rails-new -r 8.0.0 blog3 --devcontainer from Options:
-u, --ruby-version <RUBY_VERSION> [default: 3.3.4]
-r, --rails-version <RAILS_VERSION> [default: 7.2.0]
-h, --help Print help
-V, --version Print version |
@onshi The options work fine, thanks. May be we can either merge this MR or update the official doc as it targets Rails 8.0.0, but the command in the doc This worked
|
@axalix I think merging this or #23 and bumping default version to rails 8 makes much more sense than updating docs, but for this we would need Raphael's or someone from |
Added a topic on the forum here to help get this noticed |
DHH has been touring podcasts hyping rails 8, so people will visit the rails getting started guide which says to use rails-new, so they'll install rails-new and end up with rails 7.2 instead of 8, which will be confusing for new users who will then need to dig in when they notice (if they notice!) they're on rails 7.2 instead, and then they'll need to rtfm and discover that there's a -r flag and start over or w/e, etc. Just to be clear, I don't feel entitled at all to this software, and I appreciate your efforts on this free tool. I just wanted to highlight a potential issue, as it's definitely not ideal for newcomers to run into this (admittedly low) wall. |
CC: @rafaelfranca |
Summary
Update Rails version from 7.2.0 to 8.0.0