Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rails to version 8.0.0 #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

c-moyer
Copy link

@c-moyer c-moyer commented Nov 12, 2024

Summary

Update Rails version from 7.2.0 to 8.0.0

@anujdeshpande
Copy link

anujdeshpande commented Nov 24, 2024

@c-moyer do you know why this hasn't been merged already? Was hoping to give this a go without having to compile myself 😅
I was able to build and test this fine on Win11, with --devcontainer

@axalix
Copy link

axalix commented Dec 6, 2024

@c-moyer do you know why this hasn't been merged already? Was hoping to give this a go without having to compile myself 😅 I was able to build and test this fine on Win11, with --devcontainer

I wonder how this works at all https://guides.rubyonrails.org/getting_started_with_devcontainer.html#installing-rails-new - as it's about Rails 8.0, which is not really supported w/o this MR is merged. 🤕

@onshi
Copy link
Contributor

onshi commented Dec 6, 2024

@c-moyer do you know why this hasn't been merged already? Was hoping to give this a go without having to compile myself 😅 I was able to build and test this fine on Win11, with --devcontainer

I wonder how this works at all guides.rubyonrails.org/getting_started_with_devcontainer.html#installing-rails-new - as it's about Rails 8.0, which is not really supported w/o this MR is merged. 🤕

@axalix you can overwrite default ruby/rails version from dockerfile passing flags to rails-new, do you mind trying

rails-new -r 8.0.0 blog3 --devcontainer

from rais-new --help

Options:
  -u, --ruby-version <RUBY_VERSION>    [default: 3.3.4]
  -r, --rails-version <RAILS_VERSION>  [default: 7.2.0]
  -h, --help                           Print help
  -V, --version                        Print version

@axalix
Copy link

axalix commented Dec 6, 2024

@onshi The options work fine, thanks. May be we can either merge this MR or update the official doc as it targets Rails 8.0.0, but the command in the doc rails-new blog --devcontainer would target Rails 7.2.

This worked

rails-new -r 8.0.0 blog3 --devcontainer

@onshi
Copy link
Contributor

onshi commented Dec 6, 2024

@onshi The options work fine, thanks. May be we can either merge this MR or update the official doc as it targets Rails 8.0.0, but the command in the doc rails-new blog --devcontainer would target Rails 7.2.

This worked

rails-new -r 8.0.0 blog3 --devcontainer

@axalix I think merging this or #23 and bumping default version to rails 8 makes much more sense than updating docs, but for this we would need Raphael's or someone from rails org team help as I dont have permissions to merge PRs :(

@anujdeshpande
Copy link

someone from rails org team

Added a topic on the forum here to help get this noticed

@rapind
Copy link

rapind commented Dec 8, 2024

DHH has been touring podcasts hyping rails 8, so people will visit the rails getting started guide which says to use rails-new, so they'll install rails-new and end up with rails 7.2 instead of 8, which will be confusing for new users who will then need to dig in when they notice (if they notice!) they're on rails 7.2 instead, and then they'll need to rtfm and discover that there's a -r flag and start over or w/e, etc.

Just to be clear, I don't feel entitled at all to this software, and I appreciate your efforts on this free tool. I just wanted to highlight a potential issue, as it's definitely not ideal for newcomers to run into this (admittedly low) wall.

@axalix
Copy link

axalix commented Dec 8, 2024

CC: @rafaelfranca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants