add possibility to customize the name of the menu (Issue: #155) #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dc73e8f.
…ers, adjust tests
salimhb
requested changes
Jul 8, 2021
I don't think that is necessary because there was no option for the user to add a menu alias at all, so all records should have no value for menu alias. Howerver, we should check first if there are any records with an existing value for menu alias in our production database. If thats the case i will think about how to migrate them |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backendwise I added a new attribute in the companies tab for the menu alias. I noticed that there already was one for the owner but setting the menu Alias on companies was more suitable in my opinion. This attribute is also delegated to the area entity to also provide the menu name when a user is checking in