Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to filter optionally by hostgroup #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

j1n6
Copy link

@j1n6 j1n6 commented Jun 17, 2014

First, thanks for creating this awesome gem!

I am able to get most information from gem APIs, but in this case I would like to get detailed Nagios checks filtered by hostgroup.

This PR adds additional parameter hostgroup to site.service_status to filter status details by hostgroup. I've tested on Nagios v3 and v4, they do have this available in status detail view.

To be more abstract, I think this method might be better renamed to status(options), but renaming would cause API breakage for gem users - so i kept the same method name.

@j1n6
Copy link
Author

j1n6 commented Jun 26, 2014

feedbacks are welcomed.

@vStone
Copy link

vStone commented Nov 17, 2014

You should probably not include the update version commit to let the owner decide when to release a new version ;)

But i would welcome this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants