Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: final network to chainId migration + chains #6039

Merged
merged 114 commits into from
Sep 13, 2024

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Aug 23, 2024

Fixes APP-1653
Fixes APP-1704
Fixes APP-1744

  • finished the work of network => chainId refactor
  • updated send gas to use latest meteorology or provider gas if chain is not supported
  • pulling chains data from backend

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test

@estebanmino estebanmino force-pushed the @esteban/network-objects branch from 2f16cdb to c6d760c Compare August 26, 2024 18:15
@estebanmino estebanmino force-pushed the @esteban/network-objects branch 2 times, most recently from 7bcf619 to 79aa3b3 Compare August 26, 2024 19:51
@estebanmino estebanmino force-pushed the @esteban/network-objects branch from 79aa3b3 to 2740fc8 Compare August 27, 2024 16:39
@estebanmino estebanmino force-pushed the @esteban/network-objects branch from 43fcab4 to 6ec7c31 Compare August 27, 2024 17:45
@estebanmino estebanmino force-pushed the @esteban/network-objects branch 4 times, most recently from 56c9d06 to 6246069 Compare August 28, 2024 19:15
@estebanmino estebanmino force-pushed the @esteban/network-objects branch 2 times, most recently from f802b7b to 2900dd5 Compare August 28, 2024 20:43
@jinchung jinchung force-pushed the @esteban/networks-2 branch from fdf8180 to 09b99ff Compare August 28, 2024 22:10
Base automatically changed from @esteban/networks-2 to develop August 28, 2024 22:12
@estebanmino estebanmino force-pushed the @esteban/network-objects branch 5 times, most recently from a54c025 to 55c8f6d Compare September 5, 2024 17:45
@estebanmino estebanmino marked this pull request as ready for review September 5, 2024 19:12
@estebanmino estebanmino changed the title feat: network objects feat: final network to chainId migration + chains Sep 5, 2024
@estebanmino estebanmino force-pushed the @esteban/network-objects branch from c01a19c to 771d39c Compare September 6, 2024 16:30
@brunobar79
Copy link
Member

Launch in simulator or device for 91b7dd7

@estebanmino estebanmino force-pushed the @esteban/network-objects branch from b9a63ac to 7789fda Compare September 12, 2024 15:57
src/redux/gas.ts Outdated Show resolved Hide resolved
src/redux/gas.ts Outdated Show resolved Hide resolved
@brunobar79
Copy link
Member

Launch in simulator or device for 54ea3ea

Copy link
Member

@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🥑

@brunobar79
Copy link
Member

Launch in simulator or device for a537c83

@brunobar79
Copy link
Member

Launch in simulator or device for 2deb25e

@brunobar79
Copy link
Member

Launch in simulator or device for 7168d85

Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes look good, QA passed

@jinchung jinchung merged commit 71eb13f into develop Sep 13, 2024
8 checks passed
@jinchung jinchung deleted the @esteban/network-objects branch September 13, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants