-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: final network to chainId migration + chains #6039
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c91f5f
to
ca58441
Compare
2f16cdb
to
c6d760c
Compare
ca58441
to
f922848
Compare
7bcf619
to
79aa3b3
Compare
8bc861d
to
1550f82
Compare
79aa3b3
to
2740fc8
Compare
1550f82
to
f46b8fc
Compare
43fcab4
to
6ec7c31
Compare
f46b8fc
to
530fbc2
Compare
56c9d06
to
6246069
Compare
8713d29
to
b56225e
Compare
f802b7b
to
2900dd5
Compare
fdf8180
to
09b99ff
Compare
a54c025
to
55c8f6d
Compare
c01a19c
to
771d39c
Compare
b9a63ac
to
7789fda
Compare
jinchung
reviewed
Sep 12, 2024
jinchung
reviewed
Sep 12, 2024
jinchung
reviewed
Sep 12, 2024
jinchung
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮 🌮 🌮 🥑
ibrahimtaveras00
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes look good, QA passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1653
Fixes APP-1704
Fixes APP-1744
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test