ens send fix #6075
Merged
ens send fix #6075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
approved these changes
Sep 4, 2024
estebanmino
approved these changes
Sep 4, 2024
ibrahimtaveras00
pushed a commit
that referenced
this pull request
Sep 4, 2024
* fix * add gas estimation checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1844
What changed (plus any additional context for devs)
@ts-expect-errorsilenced a ts error thatnetworkwas not defined. replaced network w/ chainId, removed the ts-expect-error, and explicitly passed in the missing props asundefinedalso added the following conditions to be met before attempting gas estimation:
amountDetails.assetAmountis not an empty string (the default value)selectedasset to send is not an empty object ( the default value)Screen recordings / screenshots
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-04.at.12.48.08.mp4
What to test