-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert network accessors to functions #6219
Open
walmat
wants to merge
18
commits into
develop
Choose a base branch
from
@matthew/fix-runtime-networks
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
commented
Oct 21, 2024
walmat
commented
Oct 23, 2024
walmat
commented
Oct 23, 2024
ibrahimtaveras00
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on both OS's, QA Passed 👍🏽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
Okay so runtime support wasn't working because our accessors for backendNetworks data were all objects that only read from queryData once and never again on successive calls. I've converted all the accessors to be functions, so now we read up-to-date information when accessing.
Intro:
backendNetworksStore
.This PR also introduces a couple worklet functions to make swaps behave nicely. The only caveat is for the worklet functions, you must pass the backend network data in as a parameter. This is necessary because we cannot call
getState
inside of a worklet.Screen recordings / screenshots
N/A as it's just functional changes
What to test
Test all critical paths
would be nice to be able to coordinate some backend change to see them reflected in real-time