-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate env prod vs dev keys usage #6255
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One question: Why do we alias some env vars inside env.ts and not some others? One example in this PR is RESERVOIR_API_KEY
I think it started off with the IS_PROD vs not and some were added there in order to distinguish between PROD vs STAGING envs and expose them. Now that we don't need to do that for the RESERVOIR key, I'll follow up in another cleanup PR and remove the instances that use the env.ts for it. |
Related to APP-2008
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test