Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix token address searches on discover screen #6272

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix token address searches on discover screen #6272

merged 1 commit into from
Nov 22, 2024

Conversation

maxbbb
Copy link
Contributor

@maxbbb maxbbb commented Nov 19, 2024

Fixes APP-1674

What changed (plus any additional context for devs)

  • Incorrectly named variable "params" was replaced with correctly named variable "queryParams", which fixed mainnet address searches throwing an error.
  • tokenSearch function logic was changed to more closely match search logic in src/__swaps__/screens/Swap/resources/search/search.ts which fixed cross-chain address search.

Screen recordings / screenshots

IMG_0397 2

What to test

  • Search for an exact address on the discover screen (ex "0x6982508145454Ce325dDbE47a25d4ec3d2311933")
  • Search normally

@linear Linear
Copy link

linear bot commented Nov 19, 2024

APP-1674 Discover search should lookup ERC20 addresses across chains using token search

@brunobar79
Copy link
Member

Launch in simulator or device for a01664d

@brunobar79
Copy link
Member

Switching reviewers from @walmat to @derHowie since Matthew is OOO

@brunobar79 brunobar79 requested review from derHowie and removed request for walmat November 20, 2024 17:25
derHowie
derHowie approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Code and functionality lgtm

@brunobar79 brunobar79 added the release for release blockers and release candidate branches label Nov 22, 2024
@maxbbb maxbbb merged commit 78ba999 into develop Nov 22, 2024
8 checks passed
@maxbbb maxbbb deleted the @kane/APP-1674 branch November 22, 2024 20:12
@sentry-io Sentry.io
Copy link

sentry-io bot commented Nov 24, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: [handleDeeplink]: invalid or unknown deeplink getImportedAsset(src/hooks/useSearchCurrencyList) View Issue
  • ‼️ Error: [handleDeeplink]: invalid or unknown deeplink getImportedAsset(src/hooks/useSearchCurrencyList) View Issue
  • ‼️ Error: [handleDeeplink]: invalid or unknown deeplink getImportedAsset(src/hooks/useSearchCurrencyList) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derHowie derHowie derHowie approved these changes

@brunobar79 brunobar79 brunobar79 approved these changes

@christianbaroni christianbaroni Awaiting requested review from christianbaroni

Assignees
No one assigned
Labels
release for release blockers and release candidate branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxbbb @brunobar79 @derHowie