Skip to content
This repository has been archived by the owner on Nov 29, 2024. It is now read-only.

added metric for multiplier #54

Closed
wants to merge 1 commit into from

Conversation

Siddharth2207
Copy link
Contributor

@Siddharth2207 Siddharth2207 commented Jun 3, 2024

Motivation

Binding and charting buys and sells when twap identity is used for TKN tranche ratio denominations.

Solution

Add bindings for tranche-space when tranche ratio/base are denominated in token like WETH. Update the plottables binding, so the effective price denominated in USD can be plotted in the chart for when the twap identity is used for buys and sells.

Checks

  • Update bindings to have twap identity for buy and sell
  • unit-tested any new functionality
  • Update plottables binding to have effective price denominated in USD on the stack.

@Siddharth2207 Siddharth2207 self-assigned this Jun 3, 2024
Copy link
Contributor

@thedavidmeister thedavidmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hardyjosh @Siddharth2207 @dcatki rainlanguage/rain.orderbook#675 i wonder if we should do this before we merge this?

@Siddharth2207 Siddharth2207 requested a review from hardyjosh June 6, 2024 08:07
@Siddharth2207
Copy link
Contributor Author

@hardyjosh @Siddharth2207 @dcatki rainlanguage/rain.orderbook#675 i wonder if we should do this before we merge this?

I agree with the issue, provided it's not a scope creep in the existing work.

@hardyjosh hardyjosh closed this Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants