11/26/24 Order Charts #1026
Merged
11/26/24 Order Charts #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardingjam
force-pushed
the
11/26/24-Order-Charts-1
branch
from
3f9708f to
06fec91
Compare
hardyjosh
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ First, merge #1025
packages/ui-components/src/__tests__/ChartTimeFilters.test.svelte: Added a new test file to test theChartTimeFilterscomponent with Svelte store binding.packages/ui-components/src/__tests__/ChartTimeFilters.test.ts: Added tests to verify the functionality of theChartTimeFilterscomponent, including initial state and button click updates.packages/ui-components/src/__tests__/LightweightChart.test.ts: Added comprehensive tests for theLightweightChartcomponent, including rendering, data updates, and method calls.packages/ui-components/src/__tests__/TanstackLightweightChartLine.test.ts: Added tests for theTanstackLightweightChartLinecomponent to verify loading state, data sorting, and series addition.packages/ui-components/src/lib/__mocks__/MockComponent.svelte: Created a mock Svelte component to simulate prop updates.packages/ui-components/src/lib/__mocks__/MockComponent.ts: Added a writable store to handle mock component props.packages/ui-components/src/lib/components/charts/ChartTimeFilters.svelte: Implemented theChartTimeFilterscomponent with button tabs for different time ranges.packages/ui-components/src/lib/components/charts/LightweightChart.svelte: Created theLightweightChartcomponent with data binding, chart setup, and time scale adjustments.packages/ui-components/src/lib/components/charts/TanstackLightweightChartLine.svelte: Implemented theTanstackLightweightChartLinecomponent using theLightweightChartcomponent and data transformations.packages/ui-components/src/lib/index.ts: Added exports for the new components and mock component.packages/ui-components/src/lib/stores/darkMode.ts: Added a store to handle dark mode themes for CodeMirror and lightweight charts.Checks
By submitting this for review, I'm confirming I've done the following: