Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Makefile rule + Dockerfile to create Docker image #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Makefile rule + Dockerfile to create Docker image #1

wants to merge 1 commit into from

Conversation

harobed
Copy link

@harobed harobed commented Sep 9, 2017

No description provided.

Dieterbe
Dieterbe reviewed Sep 9, 2017
View reviewed changes
Copy link
Contributor

@Dieterbe Dieterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why hardcode such specific build variables ? I'm not convinced we should build in docker at all ? Seems like we should just let people build on their host.

@harobed
Copy link
Author

harobed commented Sep 10, 2017

Why hardcode such specific build variables ?

What variables?

@Dieterbe
Copy link
Contributor

GOOS=linux GOARCH=amd64 CGO_ENABLED=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dieterbe Dieterbe Dieterbe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harobed @Dieterbe @stephane-klein